Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to @iota/sdk #7174

Merged
merged 54 commits into from
Aug 30, 2023
Merged

chore: migrate to @iota/sdk #7174

merged 54 commits into from
Aug 30, 2023

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Jul 12, 2023 •
edited
Loading

Summary

Migrate from @iota/wallet to @iota/sdk bindings (also remove need to @iota/types)

Resolves #7116

Changelog

  • Swapped dependency to "@iota/sdk" (kept naming to @iota/wallet temporarily to start fixing import errors quicker)
  • Fix all import errors
  • Remove @iota/types dependency
  • Fix issues with webpack (this thread help i think). Fixed by pointing all imports to (@iota/sdk/out/types). Importing types must not try to load bindings binary or else webpack throws error no loader for Index.node

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Relevant changelogs:
https://github.com/iotaledger/iota-sdk/blob/develop/sdk/src/wallet/bindings/nodejs/CHANGELOG.md
https://github.com/iotaledger/iota-sdk/blob/develop/bindings/nodejs/CHANGELOG.md

  • Address all TODO-sdk comments
  • Swap "@iota/wallet" dependency name for "@iota/sdk"
  • Fix mentions of @iota/wallet in docs/standard-operating-procedures/development/releases
  • All wallet features work and tested

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@msarcev msarcev marked this pull request as draft July 12, 2023 14:52
@msarcev
feat: Point iota/wallet dependency to iota/sdk
1b66742
@msarcev
chore: Fix AddressBalance -> Balance & MintNativeTokenParams -> Creat…
fbd0617 
…eNativeTokenParams
@msarcev
chore: Migrate Node > INode, MintTokenTransaction > CreateNativeToken…
f74a531 
…Transaction, SendAmountParams > SendParams
@msarcev
chore: Fix a couple of type sources
d6b6fdc
@msarcev
chore: Fix ClientOptions > IClientOptions (rename firefly IClientOpti…
1740266 
…ons > ClientOptions to fix collision)
@msarcev
chore: Migrate EventType > WalletEventType
26fe1f6
@msarcev
chore: Migrate AccountManagerOptions > WalletOptions
3714341
@msarcev
chore: Migrate to iota/sdk models (remove @iota/types) pass 1
29c6593
@msarcev
chore: Migrate to iota/sdk models (remove @iota/types) pass 2
fb1c7cf
@msarcev
chore: Migrate to iota/sdk models (remove @iota/types) pass 3
abd219d
@msarcev
chore: Remove @iota/types dependency
0ddde68
msarcev and others added 15 commits July 31, 2023 14:39
@msarcev
chore: Fix issues after rebase (to develop). Bump iota/sdk used to 1.…
32ba0ad 
…0.2.
@msarcev
Merge branch 'develop' into migrate-to-iota-sdk
c4afa64
@msarcev
chore: Fix imports for enums (index.node loader issue fix attempt)
f6bf6e9
@msarcev
chore: Replace all sdk imports to point to '@iota/wallet/out/types'
17d7707
@msarcev
chore: Add import for 'reflect-metadata' to top of the app (needed fo…
63e7b37 
…r runtime with sdk)
@marc2332
chore: Rename AccountManager to Wallet
f11ef84
@marc2332
chore: Fix initialiseProfileManager
3222e04
@marc2332
chore: Move utility functions to electron
63d2a72
@marc2332
fix: Update getNodeInfo
5615dab
@marc2332
chore: Update sdk to v1.0.3
a927c1b
@marc2332
chore: Small fixes
3691923
@msarcev
chore: Fix "getters" from sdk in favour of readonly fields (instead o…
2352480 
…f using class-transformer)
@msarcev
chore: Bump version of @iota/sdk used
12bf34a
@msarcev
Merge branch 'develop' into migrate-to-iota-sdk
ccc4b7f
@marc2332
chore: Type fixes
a0dcec0
@brancoder brancoder self-requested a review August 18, 2023 12:11
brancoder
brancoder approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work 🎊

@marc2332 marc2332 self-requested a review August 18, 2023 14:57
@brancoder brancoder self-requested a review August 18, 2023 15:23
brancoder
brancoder requested changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When consolidating outputs there is an error account.consolidate is not a functions

image
image

begonaalvarezd
begonaalvarezd reviewed Aug 18, 2023
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@brancoder brancoder self-requested a review August 21, 2023 14:43
begonaalvarezd
begonaalvarezd requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow such amazing work 💪🏼💪🏼 💪🏼 💪🏼 💪🏼
Added some mini comments but we are almost ready to go 🚀

I havent been able to test every single feature, will keep testing and leave a comment if there is anything that needs fix

packages/desktop/components/popups/send/SendConfirmationPopup.svelte Show resolved Hide resolved
packages/desktop/index.js Show resolved Hide resolved
packages/shared/lib/core/profile-manager/api/computeOutputId.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/wallet/utils/getMetadataFromFoundryOutput.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/wallet/utils/getMetadataFromFoundryOutput.ts Outdated Show resolved Hide resolved
begonaalvarezd
begonaalvarezd requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a new test run and found that wallet finder is not working
nevermind, it was the node i was using

begonaalvarezd
begonaalvarezd approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼 🔥 amazing work

brancoder
brancoder approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌃

@begonaalvarezd begonaalvarezd changed the title Migrate to @iota/sdk chore: migrate to @iota/sdk Aug 30, 2023
@begonaalvarezd begonaalvarezd merged commit 40b6518 into develop Aug 30, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the migrate-to-iota-sdk branch August 30, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi left review comments

@brancoder brancoder brancoder approved these changes

@marc2332 marc2332 marc2332 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Migrate to new bindings @iota/sdk
5 participants
@msarcev @brancoder @begonaalvarezd @marc2332 @Tuditi