feat: Implement Monitoring Service #729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some notes about this PR:
L.E:
|
adeatcu-ionos
requested review from
a team,
rmocanu-ionos,
mimihalescu,
cristiGuranIonos,
avirtopeanu-ionos,
glimberea,
cbeti-ionos and
cciopa-ionos
and removed request for
a team
adeatcu-ionos
force-pushed
the
implement-monitoring-service
branch
2 times, most recently
from
7cb3172 to
52b7617
Compare
adeatcu-ionos
force-pushed
the
implement-monitoring-service
branch
2 times, most recently
from
4a50080 to
4a98774
Compare
adeatcu-ionos
force-pushed
the
implement-monitoring-service
branch
from
4a98774 to
ca005ff
Compare
…to implement-monitoring-service # Conflicts: # internal/framework/services/monitoring/resource_monitoring_pipeline.go # services/monitoring/pipeline.go
adeatcu-ionos
commented
Jan 8, 2025
| @@ -84,12 +84,6 @@ func PreCheck(t *testing.T) { | |||
| t.Fatalf("%s/%s or %s must be set for acceptance tests", envar.IonosUsername, envar.IonosPassword, envar.IonosToken) | |||
| } | |||
| } | |||
|
|
|||
| accessKey := os.Getenv(envar.IonosS3AccessKey) | |||
There was a problem hiding this comment.
@cristiGuranIonos It's good that you removed this since the API will complain about not setting the accessKey and the secretKey, so there is no need for us to do this check.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Checklist
feat:/fix:/doc:/test:/refactor:)