Fixed tests + docs update + merged fixes (#49)

* fixed server and group tests 

* replaced apiResponse.Status.StatusCode with apiResponse.StatusCode

* merged nic fix to accept multiple ips

* modified image_name in test with a more generic one and created documentantion for natgateway

* updated documentation + changelog + fix test

* correctly setting the active property of the s3 key upon creation and fix of NetworkLoadBalancerForwardingRule resource at setting health_check

CHANGELOG.md

@@ -1,3 +1,14 @@
+## 6.0.0-alpha.4
+
+- documentation updates
+- terraform plugin sdk upgrade to v2.4.3
+- fix: create volume without password
+- fix: ability to create server without image
+- fix: fixes #25 correctly set of dhcp + nil check + added firewall_type field in server resource
+- fix: fixes #39 - new imports for volume, user, group, share, IPfailover and loadbalancer
+- fix: fixes #47 - corrected nic resource to accept a list of strings for ips parameter
+- fix: fixes #36 - correctly setting the active property of the s3 key upon creation
+
 ## 6.0.0-alpha.3
 
 - documentation updates

docs/data-sources/k8s_node_pool.md

@@ -15,15 +15,17 @@ The k8s node pool data source can be used to search for and return existing k8s
 ```hcl
 data "ionoscloud_k8s_node_pool" "k8s_node_pool_example" {
   name     = "My_Node_Pool"
+  k8s_cluster_id 	= ionoscloud_k8s_cluster.k8s_cluster_example.id
 }
 ```
 
 ## Argument Reference
 
+* `k8s_cluster_id` (Required) K8s Cluster' UUID
 * `name` - (Optional) Name of an existing node pool that you want to search for.
 * `id` - (Optional) ID of the node pool you want to search for.
 
-Either `name` or `id` must be provided. If none, or both are provided, the datasource will return an error.
+`k8s_cluster_id` and either `name` or `id` must be provided. If none, or both of `name` and `id` are provided, the datasource will return an error.
 
 ## Attributes Reference
 

docs/data-sources/lan.md

@@ -1,6 +1,6 @@
 ---
 layout: "ionoscloud"
-page_title: "ProfitBricks : ionoscloud_lan"
+page_title: "IonosCloud : ionoscloud_lan"
 sidebar_current: "docs-ionoscloud-datasource-lan"
 description: |-
 Get information on a Ionos Cloud Lans
@@ -14,16 +14,18 @@ The lans data source can be used to search for and return existing lans.
 
 ```hcl
 data "ionoscloud_lan" "lan_example" {
-  name     = "My Lan"
+  datacenter_id = ionoscloud_datacenter.example.id
+  name			= "example_"
 }
 ```
 
 ## Argument Reference
 
+* `datacenter_id` - (Required) Datacenter's UUID.
 * `name` - (Optional) Name of an existing lan that you want to search for.
 * `id` - (Optional) ID of the lan you want to search for.
 
-Either `name` or `id` must be provided. If none, or both are provided, the datasource will return an error.
+`datacenter_id` and either `name` or `id` must be provided. If none, or both of `name` and `id` are provided, the datasource will return an error.
 
 ## Attributes Reference
 

docs/data-sources/natgateway.md

@@ -0,0 +1,39 @@
+---
+layout: "ionoscloud"
+page_title: "IonosCloud : ionoscloud_natgateway"
+sidebar_current: "docs-ionoscloud-datasource-natgateway"
+description: |-
+Get information on a Nat Gateway
+---
+
+# ionoscloud_natgateway
+
+The nat gateway data source can be used to search for and return existing natgateways.
+
+## Example Usage
+
+```hcl
+data "ionoscloud_natgateway" "natgateway_example" {
+  datacenter_id = ionoscloud_datacenter.datacenter_example.id
+  name			= "example_"
+}
+```
+
+## Argument Reference
+
+* `datacenter_id` - (Required) Datacenter's UUID.
+* `name` - (Optional) Name of an existing network loadbalancer forwarding rule that you want to search for.
+* `id` - (Optional) ID of the network loadbalancer forwarding rule you want to search for.
+
+`datacenter_id` and either `name` or `id` must be provided. If none, or both of `name` and `id` are provided, the datasource will return an error.
+
+## Attributes Reference
+
+The following attributes are returned by the datasource:
+
+* `id`
+* `name`
+* `public_ips`
+* `lans` - list of
+    * `id`
+    * `gateway_ips`

docs/data-sources/natgateway_rule.md

@@ -0,0 +1,46 @@
+---
+layout: "ionoscloud"
+page_title: "IonosCloud : ionoscloud_natgateway_rule"
+sidebar_current: "docs-ionoscloud-datasource-natgateway_rule"
+description: |-
+Get information on a Nat Gateway Rule
+---
+
+# ionoscloud_natgateway_rule
+
+The nat gateway rule data source can be used to search for and return existing natgateway rules.
+
+## Example Usage
+
+```hcl
+data "ionoscloud_natgateway_rule" "natgateway_rule_example" {
+  datacenter_id = ionoscloud_datacenter.datacenter_example.id
+  natgateway_id = ionoscloud_natgateway.natgateway_example.id
+  name			= "example_"
+}
+```
+
+## Argument Reference
+
+* `datacenter_id` - (Required) Datacenter's UUID.
+* `natgateway_id` - (Required) Nat Gateway's UUID.
+* `name` - (Optional) Name of an existing network loadbalancer forwarding rule that you want to search for.
+* `id` - (Optional) ID of the network loadbalancer forwarding rule you want to search for.
+
+Both `datacenter_id` and `natgateway_id` and either `name` or `id` must be provided. If none, or both of `name` and `id` are provided, the datasource will return an error.
+
+## Attributes Reference
+
+The following attributes are returned by the datasource:
+
+* `id`
+* `name`
+* `type`
+* `protocol`
+* `source_subnet`
+* `public_ip`
+* `target_subnet`
+* `target_port_range` - list of
+    * `start`
+    * `end`
+

docs/data-sources/networkloadbalancer.md

@@ -0,0 +1,40 @@
+---
+layout: "ionoscloud"
+page_title: "IonosCloud : ionoscloud_networkloadbalancer"
+sidebar_current: "docs-ionoscloud-datasource-networkloadbalancer"
+description: |-
+Get information on a Network Loadbalancer
+---
+
+# ionoscloud_networkloadbalancer
+
+The network loadbalancer data source can be used to search for and return existing network loadbalancers.
+
+## Example Usage
+
+```hcl
+data "ionoscloud_networkloadbalancer" "example" {
+  datacenter_id = ionoscloud_datacenter.example.id
+  name			= "example_"
+}
+```
+
+## Argument Reference
+
+* `datacenter_id` - (Required) Datacenter's UUID.
+* `name` - (Optional) Name of an existing network loadbalancer that you want to search for.
+* `id` - (Optional) ID of the network loadbalancer you want to search for.
+
+`datacenter_id` and either `name` or `id` must be provided. If none, or both of `name` and `id` are provided, the datasource will return an error.
+
+## Attributes Reference
+
+The following attributes are returned by the datasource:
+
+* `id`
+* `name`
+* `listener_lan`
+* `target_lan`
+* `ips`
+* `lb_private_ips` 
+

docs/data-sources/networkloadbalancer_forwardingrule.md

@@ -0,0 +1,56 @@
+---
+layout: "ionoscloud"
+page_title: "IonosCloud : ionoscloud_networkloadbalancer_forwardingrule"
+sidebar_current: "docs-ionoscloud-datasource-networkloadbalancer_forwardingrule"
+description: |-
+Get information on a Network Loadbalancer Forwarding Rule
+---
+
+# ionoscloud_networkloadbalancer_forwardingrule
+
+The network loadbalancer forwarding rule data source can be used to search for and return existing network forwarding rules.
+
+## Example Usage
+
+```hcl
+data "ionoscloud_networkloadbalancer_forwardingrule" "example" {
+  datacenter_id = ionoscloud_datacenter.example.id
+  networkloadbalancer_id  = ionoscloud_networkloadbalancer.example.id
+  name			= "example_"
+}
+```
+
+## Argument Reference
+
+* `datacenter_id` - (Required) Datacenter's UUID.
+* `networkloadbalancer_id` - (Required) Network Loadbalancer's UUID.
+* `name` - (Optional) Name of an existing network loadbalancer forwarding rule that you want to search for.
+* `id` - (Optional) ID of the network loadbalancer forwarding rule you want to search for.
+
+Both `datacenter_id` and `networkloadbalancer_id` and either `name` or `id` must be provided. If none, or both of `name` and `id` are provided, the datasource will return an error.
+
+## Attributes Reference
+
+The following attributes are returned by the datasource:
+
+* `id`
+* `name`
+* `algorithm`
+* `protocol`
+* `listener_ip`
+* `listener_port`
+* `health_check` - list of
+    * `client_timeout`
+    * `check_timeout`
+    * `connect_timeout`
+    * `target_timeout`
+    * `retries`
+* `targets`
+    * `ip`
+    * `port`
+    * `weight`
+    * `health_check`
+        * `check`
+        * `check_interval`
+        * `maintenance`
+

docs/data-sources/private_crossconnect.md

@@ -1,6 +1,6 @@
 ---
 layout: "ionoscloud"
-page_title: "ProfitBricks : ionoscloud_private_crossconnect"
+page_title: "IonosCloud : ionoscloud_private_crossconnect"
 sidebar_current: "docs-ionoscloud-datasource-private-crossconnect"
 description: |-
 Get information on a Ionos Cloud Private Crossconnects

docs/data-sources/server.md

@@ -1,29 +1,31 @@
 ---
 layout: "ionoscloud"
-page_title: "ProfitBricks : ionoscloud_server"
+page_title: "IonosCloud : ionoscloud_server"
 sidebar_current: "docs-ionoscloud-datasource-server"
 description: |-
 Get information on a Ionos Cloud Servers
 ---
 
 # ionoscloud\_server
 
-The lans data source can be used to search for and return existing servers.
+The server data source can be used to search for and return existing servers.
 
 ## Example Usage
 
 ```hcl
 data "ionoscloud_server" "server_example" {
-  name     = "My Server"
+   datacenter_id = ionoscloud_datacenter.datacenter_example.id
+   name			 = "example_"
 }
 ```
 
 ## Argument Reference
 
+* `datacenter_id` - (Required) Datacenter's UUID.
 * `name` - (Optional) Name of an existing server that you want to search for.
 * `id` - (Optional) ID of the server you want to search for.
 
-Either `name` or `id` must be provided. If none, or both are provided, the datasource will return an error.
+`datacenter_id` and either `name` or `id` must be provided. If none, or both of `name` and `id` are provided, the datasource will return an error.
 
 ## Attributes Reference
 

docs/data-sources/template.md

@@ -0,0 +1,41 @@
+---
+layout: "ionoscloud"
+page_title: "IonosCloud : ionoscloud_template"
+sidebar_current: "docs-ionoscloud-datasource-template"
+description: |-
+Get information on a Ionos Cloud Template
+---
+
+# ionoscloud_template
+
+The template data source can be used to search for and return existing templates.
+
+## Example Usage
+
+```hcl
+data "ionoscloud_template" "example" {
+	name = "BETA CUBES S"
+	cores = 1
+	ram	  = 2048
+	storage_size = 50
+}
+```
+
+## Argument Reference
+
+* `name` - (Required) A name of that resource.
+* `cores` - (Required) The CPU cores count.
+* `ram` - (Required) The RAM size in MB.
+* `storage_size` - (Required) The storage size in GB.
+
+All arguments must be provided. If none, the datasource will return an error.
+
+## Attributes Reference
+
+The following attributes are returned by the datasource:
+
+* `id`
+* `name`
+* `cores`
+* `ram`
+* `storage_size`

docs/resources/natgateway.md

@@ -0,0 +1,34 @@
+---
+layout: "ionoscloud"
+page_title: "IonosCloud: natgateway"
+sidebar_current: "docs-resource-natgateway"
+description: |-
+  Creates and manages Nat Gateway objects.
+---
+
+# ionoscloud_natgateway
+
+Manages a Nat Gateway on IonosCloud.
+
+## Example Usage
+
+```hcl
+resource "ionoscloud_natgateway" "example" {
+  datacenter_id = ionoscloud_datacenter.example.id
+  name          = "example"
+  public_ips    =  ["${ionoscloud_ipblock.example.ips[0]}", "${ionoscloud_ipblock.example.ips[1]}"]
+  lans {
+     id          = ionoscloud_lan.example.id
+     gateway_ips = [ "10.11.2.5/32"]
+  }
+}
+```
+
+## Argument reference
+
+- `name` - (Required)[string] Name of the NAT gateway.
+- `public_ips` - (Required)[list]Collection of public IP addresses of the NAT gateway. Should be customer reserved IP addresses in that location.
+- `lans` - (Required)[list] A list of Local Area Networks the node pool should be part of.
+  - `id` - (Required)[int] Id for the LAN connected to the NAT gateway.
+  - `gateway_ips` - (Optional)[list] Collection of gateway IP addresses of the NAT gateway. Will be auto-generated if not provided. Should ideally be an IP belonging to the same subnet as the LAN.
+- `datacenter_id` - (Required)[string] A Datacenter's UUID.