add cdn operations #460
add cdn operations #460
Conversation
|
Let's also add the changes to the changelog, as well as a bats test suite, this looks good! |
| ) | ||
|
|
||
| func Create() *core.Command { | ||
| cmd := core.NewCommand(context.Background(), nil, core.CommandBuilder{ |
There was a problem hiding this comment.
Is there a reason not to use NewCommandWithJsonProperties ?
The user might not know exactly what json we expect here for --routing-rules.
NewCommandWithJsonProperties adds two flags --json-properties and --json-properties-example. The latter if set, it prints an example json (which for example could be piped to a .json file), and exits, so the user can use that as a sort of guide
There was a problem hiding this comment.
JsonProperties is kind of vague. Having the custom name is more unambiguous. We can have a routing-rules example if we want.
There was a problem hiding this comment.
sure, then let's do that
| ) | ||
|
|
||
| func Create() *core.Command { | ||
| cmd := core.NewCommand(context.Background(), nil, core.CommandBuilder{ |
There was a problem hiding this comment.
I believe it might actually be more appropriate to have the create command use a json properties file to create the object. From what I can tell, the routing rules have quite a complex structure and it might be easier for the user to just use a properties file.
|
What does this fix or implement?
Checklist
feat:/fix:/doc:/test:/refactor:)