Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if serverId is set before making requests #103

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

rmocanu-ionos
Copy link
Contributor

What does this fix or implement?

Checklist

  • PR name added as appropriate (e.g. feat:/fix:/doc:/test:/refactor:)
  • Tests added or updated
  • Documentation updated
  • Sonar Cloud Scan
  • Changelog updated and version incremented (label: upcoming release)
  • Github Issue linked if any
  • Jira task updated

Copy link

@rmocanu-ionos rmocanu-ionos changed the base branch from master to new-release February 22, 2024 12:28
@rmocanu-ionos rmocanu-ionos merged commit b434d9d into new-release Feb 22, 2024
6 checks passed
@rmocanu-ionos rmocanu-ionos deleted the fix-missing-server-id branch February 22, 2024 12:38
rmocanu-ionos added a commit that referenced this pull request Feb 22, 2024
* build(deps): bump golang.org/x/net from 0.7.0 to 0.17.0 (#98)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0.
- [Commits](golang/net@v0.7.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github.com/docker/docker (#100)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.24+incompatible to 20.10.27+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v20.10.24...v20.10.27)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Feat/multiple lans (#102)

* feat: added additionalLans parameter

* fix: only machines in pools > 1 wait so the datacenter is created only once

* fix: correct flag name

* test: add tests

* doc: some fixes in docs, added new flag

* fix: add contains function

* fix: check if serverId is set before making requests (#103)

* doc: updated changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants