✨ Add image resolution policy #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avorima
force-pushed
the
image-resolution-policy
branch
from
722776b to
1179cb8
Compare
avorima
force-pushed
the
image-resolution-policy
branch
from
1179cb8 to
fd12eb9
Compare
avorima
force-pushed
the
image-resolution-policy
branch
from
fd12eb9 to
db70fe3
Compare
avorima
force-pushed
the
image-resolution-policy
branch
from
db70fe3 to
8c16977
Compare
avorima
force-pushed
the
image-resolution-policy
branch
from
8c16977 to
ce23e66
Compare
avorima
force-pushed
the
image-resolution-policy
branch
from
ce23e66 to
2f49162
Compare
avorima
force-pushed
the
image-resolution-policy
branch
from
2f49162 to
fc254ec
Compare
Update e2e test base image to 1.30.6
avorima
force-pushed
the
image-resolution-policy
branch
from
fc254ec to
9b80185
Compare
avorima
requested review from
piepmatz,
gfariasalves-ionos,
mcbenjemaa,
wikkyk and
jriedel-ionos
as code owners
mcbenjemaa
reviewed
Dec 6, 2024
test/e2e/capic_test.go
Outdated
| @@ -121,3 +121,17 @@ var _ = Describe("Should be able to create a cluster with 1 control-plane using | |||
| } | |||
| }) | |||
| }) | |||
|
|
|||
| var _ = Describe("Should be able to create a cluster with 1 control-plane and 2 workers using an image selector", func() { | |||
There was a problem hiding this comment.
Is it okay with long e2e runs?
We already have cases; if you want, you can set the flavor to one of them.
Another suggestion would be to label test cases and control them with PR labels.
for example capmox, have something like this:
ionos-cloud/cluster-api-provider-proxmox#352 (comment)
But. the whole e2e topic is not related to this PR.
There was a problem hiding this comment.
i think both code paths (image id and image selector) should be covered. i changed the conformance tests to use image selectors, so i think this test case can be removed.
mcbenjemaa
reviewed
Dec 6, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request/Why do we need it?
Users might want to update VM images without changing the Kubernetes version.
When using an image selector this currently requires removing labels from the old image and adding them to the new one.
I wanted to provide a better solution for this.
Issue #, if available:
Description of changes:
Add a new field
resolutionPolicyto theimageSelector. Currently only two values are allowedExactandNewest.Exactmaps to the current behavior and is the default.Newestwill use the newest entry (determined bycreatedDate) from the set of matching images.Special notes for your reviewer:
Checklist: