chore(docusaurus): update to latest #3014
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -23,12 +23,10 @@ Thanks for your interest in contributing to Ionic's documentation! :tada: Check | |||||
| In order to run the documentation locally, install the dependencies and run the development server: | ||||||
|
|
||||||
| ```sh | ||||||
| npm install | ||||||
|
There was a problem hiding this comment. The translation icon in the top menu bar appears smaller/thinner than main
There was a problem hiding this comment. I had to hide the default icon that Docusaurus renders and import a new icon via CSS. The new icon has a bolder setup. This feels a bit weird. Do we want to continue with this approach or use the default? There was a problem hiding this comment. I don't fully understand: Is the thinner icon the default or the new icon you imported via CSS? There was a problem hiding this comment. The thinner icon is the default that Docusaurus provides. Main also opts out of using the default and uses the import via CSS. The reason seems to be due to wanting a different icon at that time. Here's a screenshot of the imported icon and the default icon on main side by side.
Fast forward to today, Docusaurus has changed it's icon. It matches the one shown in main but the SVG is thinner.
I tried to match the default to main but couldn't get it so I opted to import main's icon via CSS. Realizing it now, I might be able to import the language icon from Ionicons. It might match the thickness. I'll give this a shot.
liamdebeasi marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| npm start | ||||||
|
There was a problem hiding this comment. The margins seem larger now: (top is branch, bottom is main. I added red guidelines for emphasis)
Also looks like the default arrow icon changed too. There was a problem hiding this comment. I think it's fixed. Let me know if it's still needs to be addressed. There was a problem hiding this comment. If you do see some differences. It's due to Docusaurus changing how they calculate the columns. |
||||||
| ``` | ||||||
|
There was a problem hiding this comment. The "Note" fields are no longer yellow. Is this an intentional change? Example: branch: https://ionic-docs-git-docusaurus-update-ionic1.vercel.app/docs/cli#help |
||||||
|
|
||||||
|
There was a problem hiding this comment. The Ionic logo doesn't show up in the header on the "Native" page anymore: https://ionic-docs-git-docusaurus-update-ionic1.vercel.app/docs/native There was a problem hiding this comment. Can you check if this is still an issue? I'm seeing the logo. There was a problem hiding this comment. Logo looks correct now, though I see some duplicate icons: There was a problem hiding this comment. @jaredcbaum the flickering was related to this duplicate icons. It's been fixed. |
||||||
|
There was a problem hiding this comment. The hover state looks a bit odd since there's no padding on the left: This looks like a new behavior in the latest version of Docusuarus |
||||||
| --- | ||||||
|
There was a problem hiding this comment. I can only click on the sidebar item text to expand/collapse despite the entire line being highlighted. First part of the video shows Screen.Recording.2023-08-18.at.9.13.19.AM.movThere was a problem hiding this comment. I've removed the hover styling to reflect main. Since it's no longer showing highlighted, would you still expect to click anywhere on the line or would you expect to click where the cursor is a pointer? There was a problem hiding this comment. I would expect the behavior to match what's on the production website. Note that you can click anywhere on the child links. |
||||||
|
|
||||||
| ## Using VS Code on Windows | ||||||
|
There was a problem hiding this comment. The page on mobile goes outside the viewport due to the header:
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Command+K icon in the search field has the wrong ratio:
The command symbol should roughly be the same size as the K