feat(cli): support manual signing on build command #7769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theproducer
requested review from
jcesarmobile,
eric-horodyski,
andredestro,
markemer and
EiyuuZack
|
Im open to any suggestions for better names for the new CLI flags as well. |
Comment on lines
+50
to
+54
| <key>${config.app.appId}</key> | ||
| <string>${buildOptions.xcodeProvisioningProfile ?? ''}</string> | ||
| </dict> | ||
| <key>signingCertificate</key> | ||
| <string>${buildOptions.xcodeSigningCertificate ?? ''}</string>`; |
There was a problem hiding this comment.
Will these be OK as empty strings, or would it fail the build?
There was a problem hiding this comment.
Yeah, that block is only added if signing style is manual, and if that's chosen, presumably, the developer would be supplying a provisioning profile and/or signing certificate. If what they supply is wrong (or if it's empty), then it won't work.
I believe the signing certificate can be optional, so I may push up a change to remove that key and string if the value is empty.
Honestly, they look great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7625