Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uvr16xx-blnet to latest #4298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weberk
Copy link

@weberk weberk commented Nov 17, 2024

Please add my adapter ioBroker.uvr16xx-blnet to latest.

This pull request was created by https://www.iobroker.dev c0726ff.

see ioBroker/AdapterRequests#750

@github-actions github-actions bot added the auto-checked This PR was automatically checked for obvious criterias label Nov 17, 2024
@mcm1957 mcm1957 added (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. New at LATEST labels Nov 17, 2024
Copy link

ioBroker repository information about New at LATEST tagging

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them. And please check the following information if not yet done:

You will find the results of the review and eventually issues / suggestions as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask.
mcm1957

@simatec Please take a look in respect to responsive design. Thanks

@mcm1957
Copy link
Collaborator

mcm1957 commented Nov 17, 2024

reminder 24.11.2024

@github-actions github-actions bot added the 24.11.2024 remind after 24.11.2024 label Nov 17, 2024
@github-actions github-actions bot added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Nov 25, 2024
Copy link

Automated adapter checker

ioBroker.uvr16xx-blnet

Downloads Number of Installations (latest) - Test and Release
NPM

  • ❗ [E254] Version "1.0.11" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.
  • 👀 [W401] Cannot find "uvr16xx-blnet" in latest repository
  • 👀 [W508] attribute "xs" for number should specify a value of "12" at admin/jsonConfig.json/items/_options/port
  • 👀 [W508] attribute "xs" for text should specify a value of "12" at admin/jsonConfig.json/items/_options/ip_address

Add comment "RE-CHECK!" to start check anew

@simatec
Copy link
Contributor

simatec commented Nov 25, 2024

jsonConfig looks good
jsonCustom.json5 is not in use and should be deleted

@github-actions github-actions bot added the *📬 a new comment has been added label Nov 25, 2024
@Anlop
Copy link

Anlop commented Nov 25, 2024

Habe den Adapter getestet, ich bekomme unter "Objekte" im iobroker die Werte der UVR 1611 gelesen.

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Nov 25, 2024
@weberk
Copy link
Author

weberk commented Nov 25, 2024

If I just delete the file jsonCustom.json5 but Adapter Checker complains about:
[E512] "admin/jsonCustom.json5" not found, but custom support is declared

Then I tried to set io-package.json> "supportCustoms": false,

but still https://www.iobroker.dev/adapter-check is complaining about 'custom support declared'.

Question: How to I switch custom support off?
Answer: after pushing the changes to git the issue was gone.

Now the adapter does not longer use jsonCustom.json5

@github-actions github-actions bot added the *📬 a new comment has been added label Nov 25, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Nov 26, 2024

Webbased checker is outdated. Please use commandline version or take a look at
#4298 (comment)
weberk/ioBroker.uvr16xx-blnet#6

see weberk/ioBroker.uvr16xx-blnet#6

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.11.2024 remind after 24.11.2024 auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review New at LATEST (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants