Migrated eslint to iobroker.eslint-config
#586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxriver76
reviewed
Sep 27, 2024
eslint.config.mjs
Outdated
| import config from '@iobroker/eslint-config'; | ||
|
|
||
| // disable temporary the rule 'jsdoc/require-param' and enable 'jsdoc/require-jsdoc' | ||
| config.forEach(rule => { |
There was a problem hiding this comment.
In backend adapters for sure warnings don't hurt and stuff can be fixed in the long run. So no need to disable these rules. However I have fixed all warnings
foxriver76
approved these changes
Sep 27, 2024
Apollon77
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only changes in this PR:
iobroker.eslint-configimport * as fs from 'fs'toimport { existsSync } from 'fs'(and similar)This
https://github.com/ioBroker/adapter-core/pull/586/files#diff-9601a8f6c734c2001be34a2361f76946d19a39a709b5e8c624a2a5a0aade05f2R4
could be optimized if the new
ioBroker.eslint-configwill be released ioBroker/ioBroker.eslint-config#15