feat(ui): change reset canvas button to new session menu #7356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
force-pushed
the
psyche/feat/ui/reset-canvas-to-new-session
branch
from
66c46cd
to
744a09e
Compare
hipsterusername
approved these changes
Nov 19, 2024
|
Added buttons for The adding color to this button made it not fit in, so it's just a normal base gray color. Screen.Recording.2024-11-19.at.3.50.36.pm.mov |
psychedelicious
force-pushed
the
psyche/feat/ui/reset-canvas-to-new-session
branch
from
744a09e
to
f1e7ee9
Compare
psychedelicious
deleted the
psyche/feat/ui/reset-canvas-to-new-session
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've gotten quite a bit of feedback that the reset canvas button is too similar to the delete image button, and users click one or the other and something they don't expect happens.
Replace the reset canvas button with a menu with
New Canvas SessionandNew Gallery Sessionactions. This matches the actions in the menu next to theInvokebutton.Screen.Recording.2024-11-19.at.12.31.06.pm.mov
Related Issues / Discussions
Many comments on discord
QA Instructions
It uses existing functions so the actions are identical to the invoke button menu.
Merge Plan
n/a
Checklist