fix: Avoid downloading unsafe .bin files if a safetensors file is ava… #7282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonrising
requested review from
lstein,
blessedcoolant,
RyanJDick and
hipsterusername
as code owners
github-actions
bot
added
python
psychedelicious
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Testing from a fresh env:
- Downloaded each of the starter bundles (SD1.5, SDXL, FLUX)
- Generating with SD1.5 + a couple ControlNets
- Using Select Object
- Using some filters which require a model to be run (OpenPose, LineArt)
No issues, and the SAM model only downloaded the one file. Nice!
2 tasks
hipsterusername
approved these changes
Nov 7, 2024
hipsterusername
deleted the
brandon/avoid-bin-models-when-safetensors-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ilable
Summary
Currently, if we don't detect any variants in a hf repo, we just download everything. This PR is an attempt to start avoiding downloading .bin files when we detect that a safetensors file is available in the same directory.
QA Instructions
Install
facebook/sam-vit-largeand ensure the .bin file is not downloaded and the model still functions properly.Attempt to install
mohsen2/pytorch_model.binor a similar hf repo with only .bin files and ensure the .bin is downloaded properlyMerge Plan
Can be merged when approved
Checklist
What's Newcopy (if doing a release after this PR)