Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Bitmap controls are centered manually #833

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vhosouza
Copy link
Member

Due to issue on MacOS, the navigation control buttons had the bitmap images left aligned.

To fix, the images are drawn manually.

Also removed legacy code related to the navigation controls.

KNOWN ISSUE:
For the tractography and serial_trigger buttons, if they were never activated, they get activated after the navigation is turned on and off. This should be fixed before merging.

@vhosouza vhosouza added bug neuronavigation Issues related to neuronavigation software ui/ux Bug or enhancement related to user interface and user experience labels Aug 28, 2024
@vhosouza
Copy link
Member Author

@rmatsuda, @henrikkauppi, @Rakhesis this PR is OS sensitive. Please test them in Windows and Linux.

Also, if you have a solution to the issue I raised, please commit it here or discuss with me.

@rmatsuda
Copy link
Collaborator

Its not working properly in windows. The icons are not indicating if there are disable to click, ie. keeps the same apparence always.

Copy link
Collaborator

@henrikkauppi henrikkauppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons are centered on the buttons but as mentioned by Renan, on Windows some of the disabled buttons are red when they should be gray, and even those disabled buttons that appear gray, their icons are black instead of darker shade of gray.

To illustrate this, this is what the buttons normally look like on Windows before coregistration:
before-changes

And this is what they look like now before coregistration:
after-changes

@Rakhesis
Copy link
Collaborator

Bugs on Windows:

  • Serial pulse checkbox shows red, functionally acts as if the button is disabled
  • Starting navigation enables tractography checkbox when no FOD loaded.

@Rakhesis
Copy link
Collaborator

Rakhesis commented Sep 2, 2024

On Linux, buttons seems to work the same as on Windows.

I found the same bugs that me, @henrikkauppi and @rmatsuda have already described in the comments above for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug neuronavigation Issues related to neuronavigation software ui/ux Bug or enhancement related to user interface and user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants