Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve logout description #80

Merged
merged 1 commit into from
Jun 10, 2020
Merged

docs: improve logout description #80

merged 1 commit into from
Jun 10, 2020

Conversation

mifi
Copy link
Contributor

@mifi mifi commented May 13, 2020

See #10

@CLAassistant
Copy link

CLAassistant commented May 13, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Salakar / @Ehesp based on all the research everyone did (it was a lot!) I think this change is valid even though it looks as though it is just a massive deletion (because, well it is)

Logout is basically not functioning, not used or recommended by Apple, and we should update docs to reflect that

So I'm +1 and I really appreciate @mifi taking the time to update the docs with this PR

@Salakar Salakar changed the title Improve logout description docs: improve logout description Jun 10, 2020
@Salakar Salakar merged commit ee1c1fc into invertase:master Jun 10, 2020
@Salakar
Copy link
Member

Salakar commented Jun 10, 2020

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants