Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(example): demonstrate rn76 / fabric + bridgeless works #357

Merged
merged 11 commits into from
Nov 8, 2024

Conversation

mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Nov 7, 2024

This was pretty difficult for a variety of reasons, but mostly because I had to learn react-native-test-app much more deeply.

It works though, and in fact it works on iOS, macOS (if you open the example .xcworkspace and put your dev team in the example), and visionOS

I saw no issues with fabric or bridgeless

I could be missing something? It seemed seemless though on react-native 0.76 with react-native-test-app set to "fabric_enabled" and "bridgeless_enabled" == true

the example successfully signs in on iOS 18.1 simulator and real device
with these (assuming you configure your development team in Xcode before
launching it on-device)
we are not testing multiple components here
email only comes back first sign in, but it is included in the JWT
for some reason it doesn't auto-resolve platform variants when bundling
this way? but if you specify it, it works. Then you can run on-device
even if you have problems connecting across local network to dev server
mostly nullability and deprecation items
@mikehardy mikehardy changed the title Update example to demonstrate rn76 / fabric + bridgeless works docs(example): demonstrate rn76 / fabric + bridgeless works Nov 7, 2024
@mikehardy mikehardy merged commit d45d086 into main Nov 8, 2024
6 checks passed
@mikehardy
Copy link
Collaborator Author

confirmed android "worked" as well (it needs more config but at least it builds+loads)

@mikehardy mikehardy deleted the update-example branch November 8, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new RN architectures and Fabric render
1 participant