Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for custom button text on Android #333

Merged
merged 1 commit into from
Nov 4, 2023
Merged

feat: Added support for custom button text on Android #333

merged 1 commit into from
Nov 4, 2023

Conversation

tony95271
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023

CLA assistant check
All committers have signed the CLA.

@tony95271 tony95271 changed the title added support for custom button text on Android #332 feat: added support for custom button text on Android #332 Oct 25, 2023
@tony95271 tony95271 changed the title feat: added support for custom button text on Android #332 feat: Added support for custom button text on Android Oct 25, 2023
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough, especially as it is optional. Thank you!

@mikehardy
Copy link
Collaborator

Updated the repo's CI and example app so this could get a good test, merged that to main, pulled this, rebased it to the new main with updated CI+example app, force-pushed

CI should go green then we can merge this - thanks!

@mikehardy mikehardy merged commit d2ac4b5 into invertase:main Nov 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants