Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reorder requested scopes to place FULL_NAME first #330

Merged
merged 1 commit into from
Nov 4, 2023
Merged

fix: Reorder requested scopes to place FULL_NAME first #330

merged 1 commit into from
Nov 4, 2023

Conversation

piersonmarks
Copy link
Contributor

Refer to FAQ where order of scopes matters. https://github.com/invertase/react-native-apple-authentication#faqs

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@piersonmarks piersonmarks changed the title Reorder requested scopes to place FULL_NAME first fix: Reorder requested scopes to place FULL_NAME first Oct 11, 2023
@piersonmarks piersonmarks reopened this Oct 11, 2023
mikehardy
mikehardy approved these changes Nov 4, 2023
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, thank you!

@mikehardy mikehardy merged commit b593f02 into invertase:main Nov 4, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piersonmarks @CLAassistant @mikehardy