Skip to content

Commit

Permalink
test(ci): bump runner os versions and node version in workflows
Browse files Browse the repository at this point in the history
  • Loading branch information
mikehardy committed Nov 7, 2024
1 parent fab5071 commit 2b8593a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
fetch-depth: 1
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
Expand Down
12 changes: 3 additions & 9 deletions .github/workflows/tests_e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "yarn-cache-dir-path=$(yarn cache dir)" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -66,12 +66,6 @@ jobs:
distribution: 'temurin'
java-version: '17'

- name: Verify JDK
# Default JDK varies depending on different runner flavors, make we get expected version
# Run a check that exits with error unless it is 11 version to future-proof against unexpected upgrades
run: java -fullversion 2>&1 | grep '17.0'
shell: bash

- name: Build Android App
uses: nick-fields/retry@v2
with:
Expand All @@ -85,7 +79,7 @@ jobs:
# ------------------
ios:
name: iOS
runs-on: macos-13
runs-on: macos-latest
# TODO matrix across APIs, at least 10 and 13 (lowest to highest)
timeout-minutes: 60
steps:
Expand All @@ -95,7 +89,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- uses: maxim-lobanov/setup-xcode@v1
with:
Expand Down

0 comments on commit 2b8593a

Please sign in to comment.