Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Add "View Part" action in BuildLineTable #8335

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

SchrodingersGat
Copy link
Member

Add link to view part page in BOM line item table

@SchrodingersGat SchrodingersGat added old user interface Issues with Old User interface Platform UI Related to the React based User Interface labels Oct 22, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Oct 22, 2024
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit cb7805c
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6717a0c04068280008104d91
😎 Deploy Preview https://deploy-preview-8335--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 89 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.28%. Comparing base (cb0248d) to head (cb7805c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/tables/build/BuildLineTable.tsx 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8335      +/-   ##
==========================================
+ Coverage   84.23%   84.28%   +0.04%     
==========================================
  Files        1166     1166              
  Lines       52884    52884              
  Branches     1942     1941       -1     
==========================================
+ Hits        44546    44571      +25     
+ Misses       7855     7836      -19     
+ Partials      483      477       -6     
Flag Coverage Δ
pui 66.95% <12.50%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; great addition

@SchrodingersGat SchrodingersGat merged commit cbe547b into inventree:master Oct 22, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the bo-view-part branch October 22, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old user interface Issues with Old User interface Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants