Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Sales order filters #8331

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Fixes for SalesOrderLineItem API endpoints
  • Improvements to PUI tables
  • Updated unit testing

@SchrodingersGat SchrodingersGat added order Related to purchase orders / sales orders old user interface Issues with Old User interface api Relates to the API CI CI / unit testing ecosystem Platform UI Related to the React based User Interface labels Oct 22, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Oct 22, 2024
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 7ff7ceb
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67179d4e6dadd7000835279a
😎 Deploy Preview https://deploy-preview-8331--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 89 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (cb0248d) to head (7ff7ceb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8331      +/-   ##
==========================================
+ Coverage   84.23%   84.28%   +0.04%     
==========================================
  Files        1166     1166              
  Lines       52884    52929      +45     
  Branches     1942     1942              
==========================================
+ Hits        44546    44610      +64     
+ Misses       7855     7841      -14     
+ Partials      483      478       -5     
Flag Coverage Δ
backend 85.92% <100.00%> (+0.02%) ⬆️
pui 66.85% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;
Random though: Do you think we could dynamically load the filters (including translations) from the backend? Would reduce duplication.

@SchrodingersGat SchrodingersGat merged commit ca31bb0 into inventree:master Oct 22, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the sales-order-filters branch October 22, 2024 20:16
@SchrodingersGat
Copy link
Member Author

@matmair some of the translated labels for the filters are already introspected from the API - any filter which directly matches an available field in the API endpoint can use the translated string from that field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API CI CI / unit testing ecosystem old user interface Issues with Old User interface order Related to purchase orders / sales orders Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants