-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Sales order filters #8331
[API] Sales order filters #8331
Conversation
SchrodingersGat
commented
Oct 22, 2024
- Fixes for SalesOrderLineItem API endpoints
- Improvements to PUI tables
- Updated unit testing
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8331 +/- ##
==========================================
+ Coverage 84.23% 84.28% +0.04%
==========================================
Files 1166 1166
Lines 52884 52929 +45
Branches 1942 1942
==========================================
+ Hits 44546 44610 +64
+ Misses 7855 7841 -14
+ Partials 483 478 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;
Random though: Do you think we could dynamically load the filters (including translations) from the backend? Would reduce duplication.
@matmair some of the translated labels for the filters are already introspected from the API - any filter which directly matches an available field in the API endpoint can use the translated string from that field |