Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use LABEL_DEFAULT_PRINTER user setting to pre-select plugin in label printing forms #8330

Conversation

simonkuehling
Copy link
Contributor

fixes #8313

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit aa61e9d
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6717666087b33a0008cea076
😎 Deploy Preview https://deploy-preview-8330--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 89 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (cb0248d) to head (aa61e9d).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8330      +/-   ##
==========================================
+ Coverage   84.23%   84.28%   +0.04%     
==========================================
  Files        1166     1166              
  Lines       52884    52885       +1     
  Branches     1942     1942              
==========================================
+ Hits        44546    44572      +26     
+ Misses       7855     7825      -30     
- Partials      483      488       +5     
Flag Coverage Δ
pui 66.95% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work flawlessly, clean addition!

@matmair matmair added report Report/Label generation Platform UI Related to the React based User Interface labels Oct 22, 2024
@matmair matmair added this to the 0.17.0 milestone Oct 22, 2024
@matmair matmair added the bug Identifies a bug which needs to be addressed label Oct 22, 2024
@SchrodingersGat
Copy link
Member

Nice work, thanks @simonkuehling :)

@SchrodingersGat SchrodingersGat merged commit 5ed0af2 into inventree:master Oct 23, 2024
29 checks passed
@SchrodingersGat SchrodingersGat added the plugin Plugin ecosystem label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface plugin Plugin ecosystem report Report/Label generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG/FR?] Default Label Printer setting not recognized in PUI
3 participants