Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Switch linting to biome #8317

Merged
merged 45 commits into from
Nov 12, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Oct 19, 2024

Currently eslint and prettier are setup up (probably incorrectly as they do not seem to work) in pre-commt for PUI linting/formatting. This PR replaces both with biome, which is faster, does basically the same things, and seems to work.

It also adds auto fixes for various stuff like consistent quote styles or removing unused imports.

@matmair matmair added CI CI / unit testing ecosystem refactor labels Oct 19, 2024
@matmair matmair added this to the 0.17.0 milestone Oct 19, 2024
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 8afed29
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67328bff83425a0008750276
😎 Deploy Preview https://deploy-preview-8317--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair matmair self-assigned this Nov 10, 2024
@matmair matmair marked this pull request as ready for review November 10, 2024 21:10
@matmair
Copy link
Member Author

matmair commented Nov 10, 2024

@SchrodingersGat @wolflu05 thoughts on this? No idea why eslint is not working but this fixes it.

@matmair matmair changed the title WIP: Switch PUI linting to biome [PUI] Switch linting to biome Nov 10, 2024
@SchrodingersGat
Copy link
Member

Nice this looks great @matmair

@SchrodingersGat
Copy link
Member

@wolflu05 any thoughts on this one?

@SchrodingersGat
Copy link
Member

@matmair are you happy for me to merge this?

@wolflu05
Copy link
Contributor

I have never used biome before, but it seems like a cool tool after a quick look. (it's also rust based, which promises speed). So sure we can try it out.

I would suggest adding some config for vscode to use biome as a formatter, so it works smoothly together with format on save.

@SchrodingersGat
Copy link
Member

I would suggest adding some config for vscode to use biome as a formatter, so it works smoothly together with format on save.

How would you suggest doing that?

@wolflu05
Copy link
Contributor

Seems like they have a guide about it: https://biomejs.dev/reference/vscode/

@matmair
Copy link
Member Author

matmair commented Nov 11, 2024

I have added a extension accommodation and base settings. pre-commit should ensure it is run anyhow.

@wolflu05
Copy link
Contributor

Thanks 👍

@matmair
Copy link
Member Author

matmair commented Nov 11, 2024

Thank you for your input @wolflu05 - it is valued as this whole frontend tech stuff is not really my forte.
@SchrodingersGat this is ready for review and merge from my side

@SchrodingersGat SchrodingersGat merged commit 0872bea into inventree:master Nov 12, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the switch-to-biome branch November 12, 2024 00:03
@SchrodingersGat
Copy link
Member

Awesome, great work as always @matmair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants