-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI] Switch linting to biome #8317
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@SchrodingersGat @wolflu05 thoughts on this? No idea why eslint is not working but this fixes it. |
Nice this looks great @matmair |
@wolflu05 any thoughts on this one? |
@matmair are you happy for me to merge this? |
I have never used biome before, but it seems like a cool tool after a quick look. (it's also rust based, which promises speed). So sure we can try it out. I would suggest adding some config for vscode to use biome as a formatter, so it works smoothly together with format on save. |
How would you suggest doing that? |
…switch-to-biome
Seems like they have a guide about it: https://biomejs.dev/reference/vscode/ |
I have added a extension accommodation and base settings. pre-commit should ensure it is run anyhow. |
Thanks 👍 |
Thank you for your input @wolflu05 - it is valued as this whole frontend tech stuff is not really my forte. |
Awesome, great work as always @matmair |
Currently eslint and prettier are setup up (probably incorrectly as they do not seem to work) in pre-commt for PUI linting/formatting. This PR replaces both with biome, which is faster, does basically the same things, and seems to work.
It also adds auto fixes for various stuff like consistent quote styles or removing unused imports.