Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Enhancements for serial number validation #8311

Merged
merged 14 commits into from
Oct 18, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Provide more information to plugins when running serial number generation functions
  • Improve error handling
  • Add get_latest_serial_number method to ValidationMixin class

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature plugin Plugin ecosystem labels Oct 18, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit d46271d
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6711c5bb71c5f5000814ad3c

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 42.66667% with 43 lines in your changes missing coverage. Please review.

Project coverage is 84.26%. Comparing base (c9a4e6b) to head (d46271d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/part/models.py 30.43% 16 Missing ⚠️
src/backend/InvenTree/InvenTree/helpers.py 38.88% 11 Missing ⚠️
...ee/plugin/samples/integration/validation_sample.py 37.50% 10 Missing ⚠️
src/backend/InvenTree/part/api.py 25.00% 3 Missing ⚠️
src/backend/InvenTree/plugin/plugin.py 33.33% 2 Missing ⚠️
...venTree/plugin/base/integration/ValidationMixin.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8311      +/-   ##
==========================================
- Coverage   84.29%   84.26%   -0.04%     
==========================================
  Files        1165     1165              
  Lines       52797    52845      +48     
  Branches     1931     1931              
==========================================
+ Hits        44504    44528      +24     
- Misses       7809     7833      +24     
  Partials      484      484              
Flag Coverage Δ
backend 85.90% <42.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 17bf7bb into inventree:master Oct 18, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the sn-plugin-fixes branch October 18, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature plugin Plugin ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant