Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring / Enhancements #8307

Merged
merged 29 commits into from
Oct 20, 2024

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Oct 17, 2024

WIP PR to provide historical salse information (broken down by month for e.g.) for a particular part.

Note: The original intent of this PR is probably better served as a plugin. But there are a number of fixes / improvements which are still good additions.

@SchrodingersGat SchrodingersGat added order Related to purchase orders / sales orders old user interface Issues with Old User interface api Relates to the API build Build orders feature Platform UI Related to the React based User Interface labels Oct 17, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 97e8241
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/671458bd2366f40009740b14
😎 Deploy Preview https://deploy-preview-8307--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (🟢 up 8 from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.23%. Comparing base (5f905aa) to head (97e8241).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/build/api.py 50.00% 1 Missing ⚠️
...rc/frontend/src/pages/part/PartAllocationPanel.tsx 83.33% 0 Missing and 1 partial ⚠️
src/frontend/src/tables/company/CompanyTable.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8307      +/-   ##
==========================================
- Coverage   84.35%   84.23%   -0.12%     
==========================================
  Files        1165     1166       +1     
  Lines       52845    52865      +20     
  Branches     1931     1939       +8     
==========================================
- Hits        44577    44531      -46     
- Misses       7774     7850      +76     
+ Partials      494      484      -10     
Flag Coverage Δ
backend 85.90% <83.33%> (+<0.01%) ⬆️
pui 66.69% <92.59%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat changed the title [WIP] Order History Refactoring / Enhancements Oct 19, 2024
@SchrodingersGat SchrodingersGat added refactor and removed order Related to purchase orders / sales orders api Relates to the API build Build orders feature labels Oct 19, 2024
- Do not request token if other cookies are unavailable
- Do not fetch user data if token is unavailable
- Prevents connection error logs
Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of small things, seems reasonable

@SchrodingersGat SchrodingersGat merged commit 29726d8 into inventree:master Oct 20, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the sales-histroy branch October 20, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old user interface Issues with Old User interface Platform UI Related to the React based User Interface refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants