Fix for update_pricing method: #7075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SchrodingersGat
commented
Apr 22, 2024
SchrodingersGat
commented
- Specify currency
- Handle case where quantity is zero
- Ref: [bug] pricing autofill in purchase orders #4902 (comment)
- Specify currency - Handle case where quantity is zero
SchrodingersGat
added
bug
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7075 +/- ##
==========================================
- Coverage 83.24% 83.24% -0.01%
==========================================
Files 1038 1038
Lines 45493 45493
Branches 1244 1244
==========================================
- Hits 37870 37869 -1
- Misses 7376 7377 +1
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
- Specify currency - Handle case where quantity is zero (cherry picked from commit 50ca493)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
SchrodingersGat
added a commit
that referenced
this pull request
Apr 22, 2024
- Specify currency - Handle case where quantity is zero (cherry picked from commit 50ca493) Co-authored-by: Oliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.