Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Pricing UX improvements #7053

Merged
merged 13 commits into from
Apr 16, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Apr 16, 2024

Ref #7025

Addresses some small UI/UX things
grafik

@matmair matmair added the Platform UI Related to the React based User Interface label Apr 16, 2024
@matmair matmair added this to the 0.15.0 milestone Apr 16, 2024
@matmair matmair self-assigned this Apr 16, 2024
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 9f16d3f
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/661f05f309e09900081376d5
😎 Deploy Preview https://deploy-preview-7053--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair
Copy link
Member Author

matmair commented Apr 16, 2024

grafik
Not with currency formatting support

@matmair matmair marked this pull request as ready for review April 16, 2024 23:14
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 27.14286% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 83.14%. Comparing base (5bf246c) to head (9f16d3f).

Files Patch % Lines
src/frontend/src/pages/part/PartPricingPanel.tsx 50.00% 5 Missing and 7 partials ⚠️
...rontend/src/pages/part/pricing/PriceBreakPanel.tsx 0.00% 6 Missing ⚠️
...nd/src/pages/part/pricing/PricingOverviewPanel.tsx 0.00% 5 Missing and 1 partial ⚠️
...nd/src/pages/part/pricing/PurchaseHistoryPanel.tsx 0.00% 6 Missing ⚠️
...ontend/src/pages/part/pricing/SaleHistoryPanel.tsx 0.00% 6 Missing ⚠️
...nd/src/pages/part/pricing/SupplierPricingPanel.tsx 0.00% 6 Missing ⚠️
...rontend/src/pages/part/pricing/BomPricingPanel.tsx 0.00% 5 Missing ⚠️
...rontend/src/components/charts/tooltipFormatter.tsx 0.00% 2 Missing ⚠️
...end/src/pages/part/pricing/VariantPricingPanel.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7053      +/-   ##
==========================================
- Coverage   83.30%   83.14%   -0.16%     
==========================================
  Files        1038     1039       +1     
  Lines       45495    45562      +67     
  Branches     1243     1270      +27     
==========================================
- Hits        37901    37884      -17     
- Misses       7341     7419      +78     
- Partials      253      259       +6     
Flag Coverage Δ
pui 56.42% <27.14%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

Very nice improvements @matmair , thanks!

@SchrodingersGat SchrodingersGat merged commit 9435a4c into inventree:master Apr 16, 2024
27 of 28 checks passed
@SchrodingersGat SchrodingersGat deleted the matmair/issue7025 branch April 16, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants