Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOM pricing table fix #7044

Merged

Conversation

SchrodingersGat
Copy link
Member

Small tweaks for BOM table and BOM pricing table

@SchrodingersGat SchrodingersGat added old user interface Issues with Old User interface Platform UI Related to the React based User Interface labels Apr 15, 2024
@SchrodingersGat SchrodingersGat added this to the 0.15.0 milestone Apr 15, 2024
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 097e1ee
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/661db95bb734970007ce7dc2
😎 Deploy Preview https://deploy-preview-7044--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 83.36%. Comparing base (d3a2ece) to head (097e1ee).
Report is 1 commits behind head on master.

Files Patch % Lines
src/frontend/src/tables/bom/BomTable.tsx 0.00% 6 Missing ⚠️
...rontend/src/pages/part/pricing/BomPricingPanel.tsx 0.00% 4 Missing ⚠️
src/frontend/src/tables/bom/UsedInTable.tsx 0.00% 4 Missing ⚠️
src/frontend/src/tables/ColumnRenderers.tsx 33.33% 0 Missing and 2 partials ⚠️
...end/src/pages/part/pricing/VariantPricingPanel.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7044      +/-   ##
==========================================
- Coverage   83.39%   83.36%   -0.04%     
==========================================
  Files        1038     1038              
  Lines       45472    45486      +14     
  Branches     1238     1243       +5     
==========================================
- Hits        37921    37919       -2     
- Misses       7296     7320      +24     
+ Partials      255      247       -8     
Flag Coverage Δ
pui 57.73% <5.55%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 9d2297d into inventree:master Apr 15, 2024
27 of 28 checks passed
@SchrodingersGat SchrodingersGat deleted the bom-pricing-table-fix branch April 15, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old user interface Issues with Old User interface Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant