Skip to content

Small SAST fixes #15900

Small SAST fixes

Small SAST fixes #15900

Triggered via pull request November 25, 2024 21:52
Status Success
Total duration 23m 0s
Artifacts 1

qc_checks.yaml

on: pull_request
Build - UI Platform
2m 6s
Build - UI Platform
Style [pre-commit]
34s
Style [pre-commit]
Tests - API Schema Documentation
0s
Tests - API Schema Documentation
Style [Documentation]
44s
Style [Documentation]
Tests - Migrations [PostgreSQL]
0s
Tests - Migrations [PostgreSQL]
Tests - Full Migration [SQLite]
0s
Tests - Full Migration [SQLite]
Tests - inventree-python
0s
Tests - inventree-python
Tests - DB [PostgreSQL]
0s
Tests - DB [PostgreSQL]
Tests - DB [MySQL]
0s
Tests - DB [MySQL]
Tests - Platform UI
22m 0s
Tests - Platform UI
Matrix: coverage
Style - Classic UI [JS]
1m 26s
Style - Classic UI [JS]
Push new schema
0s
Push new schema
Fit to window
Zoom out
Zoom in

Annotations

7 errors, 8 warnings, and 1 notice
[chromium] › pages/pui_part.spec.ts:61:1 › Parts - Supplier Parts: src/frontend/tests/pages/pui_part.spec.ts#L1
1) [chromium] › pages/pui_part.spec.ts:61:1 › Parts - Supplier Parts ───────────────────────────── Test timeout of 90000ms exceeded.
[chromium] › pages/pui_part.spec.ts:61:1 › Parts - Supplier Parts: src/frontend/tests/login.ts#L37
1) [chromium] › pages/pui_part.spec.ts:61:1 › Parts - Supplier Parts ───────────────────────────── Error: locator.waitFor: Test timeout of 90000ms exceeded. Call log: - waiting for getByText(/InvenTree Demo Server -/) to be visible at login.ts:37 35 | await page.waitForURL('**/platform/home'); 36 | > 37 | await page.getByText(/InvenTree Demo Server -/).waitFor(); | ^ 38 | }; 39 | 40 | export const doLogout = async (page) => { at doQuickLogin (/home/runner/work/InvenTree/InvenTree/src/frontend/tests/login.ts:37:51) at /home/runner/work/InvenTree/InvenTree/src/frontend/tests/pages/pui_part.spec.ts:62:3
[chromium] › pages/pui_purchase_order.spec.ts:82:1 › Purchase Orders - Receive Items: src/frontend/tests/pages/pui_purchase_order.spec.ts#L1
2) [chromium] › pages/pui_purchase_order.spec.ts:82:1 › Purchase Orders - Receive Items ────────── Test timeout of 90000ms exceeded.
[chromium] › pages/pui_purchase_order.spec.ts:82:1 › Purchase Orders - Receive Items: src/frontend/tests/pages/pui_purchase_order.spec.ts#L96
2) [chromium] › pages/pui_purchase_order.spec.ts:82:1 › Purchase Orders - Receive Items ────────── Error: locator.click: Test timeout of 90000ms exceeded. Call log: - waiting for getByLabel('action-button-receive-items') - locator resolved to <button disabled type="button" data-disabled="true" data-variant="transparent" aria-label="action-button-receive-items" class="mantine-focus-auto m_8d3f4000 mantine-ActionIcon-root m_87cf2631 mantine-UnstyledButton-root">…</button> - attempting click action - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #1 - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #2 - waiting 20ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #3 - waiting 100ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #4 - waiting 100ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #5 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #6 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #7 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #8 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #9 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #10 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #11 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #12 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #13 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #14 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #15 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #16 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #17 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #18 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #19 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #20 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #21 - waiting 500ms - waiting for element to be visible, enabled and stable - element is not enabled - retrying click action, attempt #22 - waiti
[firefox] › pages/pui_part.spec.ts:165:1 › Parts - Pricing (Nothing: src/frontend/tests/pages/pui_part.spec.ts#L1
3) [firefox] › pages/pui_part.spec.ts:165:1 › Parts - Pricing (Nothing, BOM) ───────────────────── Test timeout of 90000ms exceeded.
[firefox] › pages/pui_part.spec.ts:165:1 › Parts - Pricing (Nothing: src/frontend/tests/login.ts#L37
3) [firefox] › pages/pui_part.spec.ts:165:1 › Parts - Pricing (Nothing, BOM) ───────────────────── Error: locator.waitFor: Test timeout of 90000ms exceeded. Call log: - waiting for getByText(/InvenTree Demo Server -/) to be visible at login.ts:37 35 | await page.waitForURL('**/platform/home'); 36 | > 37 | await page.getByText(/InvenTree Demo Server -/).waitFor(); | ^ 38 | }; 39 | 40 | export const doLogout = async (page) => { at doQuickLogin (/home/runner/work/InvenTree/InvenTree/src/frontend/tests/login.ts:37:51) at /home/runner/work/InvenTree/InvenTree/src/frontend/tests/pages/pui_part.spec.ts:166:3
[firefox] › pui_login.spec.ts:5:1 › Login - Basic Test: src/frontend/tests/baseFixtures.ts#L85
4) [firefox] › pui_login.spec.ts:5:1 › Login - Basic Test ──────────────────────────────────────── Error: expect(received).toEqual(expected) // deep equality - Expected - 1 + Received + 258 - Array [] + Array [ + ConsoleMessage { + "_event": Object { + "args": Array [ + EventEmitter { + "_events": Object { + "previewUpdated": [Function anonymous], + }, + "_eventsCount": 1, + "_maxListeners": undefined, + "_object": Object { + "_guid": "handle@7ccaa6f7b8246d77cc0eb999309e13e7", + "_type": "JSHandle", + }, + "_pendingHandlers": Map {}, + "_rejectionHandler": undefined, + "off": [Function removeListener], + "on": [Function addListener], + }, + ], + "location": Object { + "columnNumber": 19, + "lineNumber": 2599, + "url": "http://localhost:5173/node_modules/.vite/deps/chunk-56VRJ6UA.js?v=4605c1a9", + }, + "page": EventEmitter { + "_events": Object { + "bindingCall": [Function anonymous], + "close": [Function anonymous], + "crash": [Function anonymous], + "download": [Function anonymous], + "fileChooser": [Function anonymous], + "frameAttached": [Function anonymous], + "frameDetached": [Function anonymous], + "locatorHandlerTriggered": [Function anonymous], + "route": [Function anonymous], + "video": [Function anonymous], + "webSocket": [Function anonymous], + "worker": [Function anonymous], + }, + "_eventsCount": 12, + "_maxListeners": undefined, + "_object": Object { + "_guid": "page@a029970ffc362ec9b75b1c392a18b944", + "_type": "Page", + }, + "_pendingHandlers": Map {}, + "_rejectionHandler": undefined, + "off": [Function removeListener], + "on": [Function addListener], + }, + "text": "The above error occurred in one of your React components: + + Lazy + Suspense + RenderedRoute@http://localhost:5173/node_modules/.vite/deps/react-router-dom.js?v=bb5b5370:4095:7 + Outlet@http://localhost:5173/node_modules/.vite/deps/react-router-dom.js?v=bb5b5370:4467:20 + _ErrorBoundary@http://localhost:5173/node_modules/.vite/deps/@sentry_react.js?v=ef92b644:22660:5 + Boundary@http://localhost:5173/src/components/Boundary.tsx:999:25 + div + _Box<@http://localhost:5173/node_modules/.vite/deps/chunk-56VRJ6UA.js?v=4605c1a9:3819:3 + Container<@http://localhost:5173/node_modules/.vite/deps/chunk-56VRJ6UA.js?v=4605c1a9:15473:25 + div + _Box<@http://localhost:5173/node_modules/.vite/deps/chunk-56VRJ6UA.js?v=4605c1a9:3819:3 + Flex<@http://localhost:5173/node_modules/.vite/deps/chunk-56VRJ6UA.js?v=4605c1a9:10002:25 + ProtectedRoute@http://localhost:5173/src/components/nav/Layout.tsx:1341:31 + LayoutComponent@http://localhost:5173/src/components/nav/Layout.tsx:1386:47 + Suspense + RenderedRoute@http://localhost:5173/node_modules/.vite/deps/react-router-dom.js?v=bb5b5370:4095:7 + Routes@http://localhost:5173/node_modules/.vite/deps/react-router-dom.js?v=bb5b5370:4533:7 + Router@http://localhost:5173/node_modules/.vite/deps/react-router-dom.js?v=bb5b5370:4481:7 + BrowserRouter@http://localhost:5173/node_modules/.vite/deps/react-router-dom.js?v=bb5b5370:5223:7 + QueryClientProvider@http://localhost:5173/node_modules/.vite/deps/@tanstack_react-query.js?v=de530777:2725:27 + ModalsProvider@http://localhost:5173/node_modules/.vite/deps/@mantine_modals.js?v=f5d8430a:184:24 + I18nProvider@http://localhost:5173/node_modules/.vite/deps/@lingui_react.js?v=51c0877b:159:20 + LanguageContext@http://localhos
Build - UI Platform
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Style - Classic UI [JS]
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests - Platform UI
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Slow Test: src/frontend/[firefox] › pages/pui_purchase_order.spec.ts#L1
src/frontend/[firefox] › pages/pui_purchase_order.spec.ts took 35.2s
Slow Test: src/frontend/[chromium] › pages/pui_scan.spec.ts#L1
src/frontend/[chromium] › pages/pui_scan.spec.ts took 33.7s
Slow Test: src/frontend/[chromium] › pages/pui_sales_order.spec.ts#L1
src/frontend/[chromium] › pages/pui_sales_order.spec.ts took 30.8s
Slow Test: src/frontend/[chromium] › modals.spec.ts#L1
src/frontend/[chromium] › modals.spec.ts took 20.8s
Slow Test: src/frontend/[firefox] › pui_command.spec.ts#L1
src/frontend/[firefox] › pui_command.spec.ts took 16.9s
🎭 Playwright Run Summary
4 flaky [chromium] › pages/pui_part.spec.ts:61:1 › Parts - Supplier Parts ────────────────────────────── [chromium] › pages/pui_purchase_order.spec.ts:82:1 › Purchase Orders - Receive Items ─────────── [firefox] › pages/pui_part.spec.ts:165:1 › Parts - Pricing (Nothing, BOM) ────────────────────── [firefox] › pui_login.spec.ts:5:1 › Login - Basic Test ───────────────────────────────────────── 130 passed (15.0m)

Artifacts

Produced during runtime
Name Size
frontend-build
2.21 MB