Error codes #126
Merged
Error codes #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
force-pushed
the
error-codes
branch
from
16dfc0d to
d7cb6b5
Compare
ntarocco
approved these changes
Feb 13, 2024
| @@ -149,8 +149,10 @@ def _raise_status(self, path, status): | |||
| """Raise error based on status.""" | |||
| # 3006 - legacy (v4 errno), 17 - POSIX error, 3018 (xrootd v5 errno) | |||
| if status.errno in [3006, 17, 3018]: | |||
| if status.message.strip().endswith("directory not empty"): | |||
There was a problem hiding this comment.
thanks for the suggestion, I added it to our generic issue about improving errors, for now I patched it until we have some breathing room for proper solution
see #122
| @@ -405,7 +407,7 @@ def removedir(self, path, recursive=False, force=False): | |||
| status, _ = self._client.rmdir(self._p(path)) | |||
|
|
|||
| if not status.ok: | |||
| directory_not_empty_error = status.errno == 3005 | |||
| directory_not_empty_error = status.errno in [3005, 3018] | |||
There was a problem hiding this comment.
it looks like that 3005 is not that error, it is a bit misleading (it was there before).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.