Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subjects: improve search with CompositeSuggestQueryParser #448

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ptamarit
Copy link
Member

@ptamarit ptamarit commented Dec 5, 2024

❤️ Thank you for your contribution!

Description

  • Fixes Improve MeSH search results #447 (see details in linked issue)
  • The feature allowing to search by prefix (e.g. EuroSciVoc:dementia) used to have a corresponding UI automatically adding the prefixed filter.
    Now that this is not in the UI anymore, since this search behavior is not documented, and since the search results of FilteredSuggestQueryParser are not good, we are proposing to:
    • Deprecate FilteredSuggestQueryParser
    • Use the recently introduced CompositeSuggestQueryParser, which narrows down results as more search terms are added

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@ptamarit ptamarit force-pushed the 447-mesh-search-improve branch from f49883d to f0fcf4c Compare December 9, 2024 08:10
@ptamarit ptamarit changed the title subjects: improve search subjects: improve search with CompositeSuggestQueryParser Dec 9, 2024
@ptamarit ptamarit force-pushed the 447-mesh-search-improve branch from f0fcf4c to 13a1fca Compare December 9, 2024 08:47
@slint slint merged commit c263b38 into inveniosoftware:master Dec 9, 2024
4 checks passed
@ptamarit ptamarit deleted the 447-mesh-search-improve branch December 9, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve MeSH search results
2 participants