datastream: optimize memory usage on ORCID sync #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
reviewed
Nov 22, 2024
jrcastro2
force-pushed
the
improve-orcid-sync
branch
2 times, most recently
from
dec7ae4 to
05b5d79
Compare
kpsherva
reviewed
Nov 25, 2024
kpsherva
reviewed
Nov 25, 2024
| yield result | ||
| } | ||
|
|
||
| for orcid, future in list(futures.items()): |
There was a problem hiding this comment.
is casting to list needed?
There was a problem hiding this comment.
Could also be just iterating of list(futures.keys()), since the reason is that we're modifying the futures dictionary as we iterate over the keys. So "consuming" the iterator iterator is necessary. See also #439 (comment)
jrcastro2
force-pushed
the
improve-orcid-sync
branch
from
05b5d79 to
445c2ff
Compare
jrcastro2
force-pushed
the
improve-orcid-sync
branch
2 times, most recently
from
0e7dae6 to
b60d386
Compare
jrcastro2
force-pushed
the
improve-orcid-sync
branch
3 times, most recently
from
947daf4 to
375c51d
Compare
jrcastro2
force-pushed
the
improve-orcid-sync
branch
from
375c51d to
458dc72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.