search: improve with CompositeSuggestQueryParser #151
Conversation
ptamarit
changed the title
ptamarit
force-pushed
the
150-user-search-improve
branch
from
ee9e9e7 to
eb1fcfa
Compare
| fields=["username^2", "email^2", "profile.full_name^3", "profile.affiliations"], | ||
| fields=[ | ||
| "username^2", | ||
| "email.keyword^2", |
There was a problem hiding this comment.
email had to be changed to email.keyword for the tests to pass.
There was a problem hiding this comment.
Minor: Maybe we could keep the email text field as well, might be useful, wdyt?
| "email.keyword^2", | |
| "email.keyword^2", | |
| "email^2", |
| @@ -81,7 +86,6 @@ class UserSearchOptions(SearchOptions, SearchOptionsMixin): | |||
| "name": "profile.full_name", | |||
| }, | |||
| type="most_fields", # https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-multi-match-query.html#multi-match-types | |||
| fuzziness="AUTO", # https://www.elastic.co/guide/en/elasticsearch/reference/current/common-options.html#fuzziness | |||
There was a problem hiding this comment.
fuzziness is applied in CompositeSuggestQueryParser.
| tree_transformer_cls=SearchFieldTransformer, | ||
| fields=["username^2", "email^2", "profile.full_name^3", "profile.affiliations"], | ||
| fields=[ | ||
| "username^2", |
There was a problem hiding this comment.
Searching for a username with a dash is still not working well.
For instance, searching from "one-two" seems to search for usernames starting with "one" and starting with "two", and therefore does not find anything.
There was a problem hiding this comment.
I think this is the issue: text field is split by - https://github.com/inveniosoftware/invenio-users-resources/blob/master/invenio_users_resources/records/mappings/os-v2/users/user-v3.0.0.json#L132
if you search by username.keyword, it should work
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: