permissions: add generator for handling groups enabled feature flag #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikachurilova
commented
Apr 16, 2024
| @@ -123,3 +125,28 @@ def query_filter(self, **kwargs): | |||
| return q_all & else_query | |||
|
|
|||
| return q_not_managed & then_query | |||
|
|
|||
|
|
|||
| class GroupsEnabled(Generator): | |||
There was a problem hiding this comment.
anikachurilova
force-pushed
the
add-groups-enabled-permission-generator
branch
from
1d31830 to
ca575b4
Compare
ntarocco
reviewed
Apr 19, 2024
anikachurilova
force-pushed
the
add-groups-enabled-permission-generator
branch
from
ca575b4 to
4c37d9d
Compare
anikachurilova
commented
Apr 23, 2024
|
|
||
| def excludes(self, member_types=None, **kwargs): | ||
| """Preventing needs.""" | ||
| member_types = member_types or {"group"} |
There was a problem hiding this comment.
Note: added default member_types (different from the old code)
anikachurilova
force-pushed
the
add-groups-enabled-permission-generator
branch
2 times, most recently
from
cd2532a to
9f1ca10
Compare
anikachurilova
force-pushed
the
add-groups-enabled-permission-generator
branch
from
9f1ca10 to
f36d0af
Compare
ntarocco
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
access/groupsendpoint invenio-rdm-records#1672