Skip to content

Commit

Permalink
wip: index new groups in OpenSearch
Browse files Browse the repository at this point in the history
 * changed number of workers per celery task based on task type
 * closes inveniosoftware/invenio-app-rdm#2186
  • Loading branch information
TLGINO committed May 28, 2023
1 parent 3c7d05b commit 0e3a405
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 48 deletions.
21 changes: 9 additions & 12 deletions invenio_users_resources/records/hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,15 @@ def post_commit(sender, session):
# DB operations are allowed here, not even lazy-loading of
# properties!
sid = id(session)
if current_db_change_history.sessions.get(sid):
for user_id in current_db_change_history.sessions[sid].updated_users:
reindex_user.delay(user_id)

for role_id in current_db_change_history.sessions[sid].updated_roles:
reindex_group.delay(role_id)
reindex_user_roles = current_db_change_history.updated_users[sid]
reindex_group_roles = current_db_change_history.updated_roles[sid]
unindex_user_roles = current_db_change_history.deleted_users[sid]
unindex_group_roles = current_db_change_history.deleted_roles[sid]

for user_id in current_db_change_history.sessions[sid].deleted_users:
unindex_user.delay(user_id)
reindex_user.delay(reindex_user_roles)
reindex_group.delay(reindex_group_roles)
unindex_user.delay(unindex_user_roles)
unindex_group.delay(unindex_group_roles)

for role_id in current_db_change_history.sessions[sid].deleted_roles:
unindex_group.delay(role_id)

current_db_change_history.sessions[sid].indexed = True
current_db_change_history.clear_session(sid)
current_db_change_history._clear_dirty_sets(session)
34 changes: 18 additions & 16 deletions invenio_users_resources/services/groups/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,24 +18,26 @@


@shared_task(ignore_result=True)
def reindex_group(role_id):
def reindex_group(role_ids):
"""Reindex the given user."""
index = current_groups_service.record_cls.index
if current_groups_service.indexer.exists(index):
try:
group_agg = GroupAggregate.get_record(role_id)
current_groups_service.indexer.index(group_agg)
except search.exceptions.ConflictError as e:
current_app.logger.warn(f"Could not reindex group {role_id}: {e}")
for role_id in role_ids:
index = current_groups_service.record_cls.index
if current_groups_service.indexer.exists(index):
try:
group_agg = GroupAggregate.get_record(role_id)
current_groups_service.indexer.index(group_agg)
except search.exceptions.ConflictError as e:
current_app.logger.warn(f"Could not reindex group {role_id}: {e}")


@shared_task(ignore_result=True)
def unindex_group(role_id):
def unindex_group(role_ids):
"""Unindex the given role/group."""
index = current_groups_service.record_cls.index
if current_groups_service.indexer.exists(index):
try:
group_agg = GroupAggregate.get_record(role_id)
current_groups_service.indexer.delete(group_agg)
except search.exceptions.ConflictError as e:
current_app.logger.warn(f"Could not unindex group {role_id}: {e}")
for role_id in role_ids:
index = current_groups_service.record_cls.index
if current_groups_service.indexer.exists(index):
try:
group_agg = GroupAggregate.get_record(role_id)
current_groups_service.indexer.delete(group_agg)
except search.exceptions.ConflictError as e:
current_app.logger.warn(f"Could not unindex group {role_id}: {e}")
42 changes: 22 additions & 20 deletions invenio_users_resources/services/users/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,30 @@


@shared_task(ignore_result=True)
def reindex_user(user_id):
def reindex_user(user_ids):
"""Reindex the given user."""
index = current_users_service.record_cls.index
if current_users_service.indexer.exists(index):
try:
user_agg = UserAggregate.get_record(user_id)
current_users_service.indexer.index(user_agg)
# trigger reindexing of related records
send_change_notifications(
"users", [(user_agg.id, str(user_agg.id), user_agg.revision_id)]
)
except search.exceptions.ConflictError as e:
current_app.logger.warn(f"Could not reindex user {user_id}: {e}")
for user_id in user_ids:
index = current_users_service.record_cls.index
if current_users_service.indexer.exists(index):
try:
user_agg = UserAggregate.get_record(user_id)
current_users_service.indexer.index(user_agg)
# trigger reindexing of related records
send_change_notifications(
"users", [(user_agg.id, str(user_agg.id), user_agg.revision_id)]
)
except search.exceptions.ConflictError as e:
current_app.logger.warn(f"Could not reindex user {user_id}: {e}")


@shared_task(ignore_result=True)
def unindex_user(user_id):
def unindex_user(user_ids):
"""Delete the given user from the index."""
index = current_users_service.record_cls.index
if current_users_service.indexer.exists(index):
try:
user_agg = UserAggregate.get_record(user_id)
current_users_service.indexer.delete(user_agg)
except search.exceptions.ConflictError as e:
current_app.logger.warn(f"Could not unindex user {user_id}: {e}")
for user_id in user_ids:
index = current_users_service.record_cls.index
if current_users_service.indexer.exists(index):
try:
user_agg = UserAggregate.get_record(user_id)
current_users_service.indexer.delete(user_agg)
except search.exceptions.ConflictError as e:
current_app.logger.warn(f"Could not unindex user {user_id}: {e}")

0 comments on commit 0e3a405

Please sign in to comment.