Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trans string #143

Closed
wants to merge 4 commits into from
Closed

trans string #143

wants to merge 4 commits into from

Conversation

mb-wali
Copy link
Contributor

@mb-wali mb-wali commented Feb 10, 2020 •
edited
Loading

Templates for mentioned issues: #140, #138, #137, #141, #139 & #142 .
mostly in these templates, the strings were marked, but I have double-checked and found some.

regarding flask menu i am afraid they are dynamic this approach will not work. I opened an issue for this #144 .

PS. there was a CI failed to build, this is because of werkzeug latest version, I have limited to werkzeug==0.16.1 version.

@mb-wali mb-wali closed this Feb 10, 2020
@mb-wali mb-wali deleted the trans branch February 10, 2020 09:11
@mb-wali mb-wali restored the trans branch February 10, 2020 09:12
@mb-wali mb-wali reopened this Feb 10, 2020
@mb-wali mb-wali requested a review from zzacharo February 10, 2020 12:51
@zzacharo
Copy link
Member

Superseded by #193. @mb-wali sorry for that, your changes were already included in the mentioned PR. It was a clear miscommunication that ended up to do the job twice :)

@zzacharo zzacharo closed this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzacharo zzacharo Awaiting requested review from zzacharo

Assignees

@zzacharo zzacharo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mb-wali @zzacharo