Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix imports in conftest.py #31

Merged
merged 4 commits into from
Feb 17, 2024

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Feb 12, 2024

❤️ Thank you for your contribution!

Description

  • Fix breaking tests: In conftest.py, the testing mock utility from moto import mock_s3 has been updated to mock_aws. as mock_s3 is been deprecated and breaking tests.
  • Dependency Update: In setup.cfg, the dependency pytest-black has been replaced with pytest-black-ng, and the Sphinx version constraint has been relaxed from a fixed version ==4.2.0 to >=4.2.0.
  • Code Modernization: Removal of from future import. This indicates a move away from Python 2 compatibility layers, transitioning to Python 3 as the minimum supported version.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13 Samk13 requested a review from utnapischtim February 13, 2024 14:11
@utnapischtim
Copy link
Contributor

Overall looks good to me.
NOTE: you could update the github/actions in the tests.yml and pypi-publish.yml file as in this commit. this prevents warnings for usage of node12 or node14

Copy link

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@egabancho egabancho merged commit 9b1335b into inveniosoftware:master Feb 17, 2024
2 checks passed
@Samk13 Samk13 deleted the update-package branch February 19, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To release 🔧
Development

Successfully merging this pull request may close these issues.

4 participants