Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests Comment: fix jumping cursor #392

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Jul 3, 2024

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

cursor-test-1

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13 Samk13 force-pushed the fix-jumping-cursor branch from ec5e66b to c65ab1b Compare July 3, 2024 22:11
* these changes depending on thins PR: inveniosoftware/react-invenio-forms#244
* align porperty naming as RichEditior wrongly named value instead of initialValue
* change onchange to onEditorChange as recommended in the tinymce docs.
* Change the prop value to inputValue, as the name value seems to conflict with other elements, causing the input text in edit mode to behave oddly.
@Samk13 Samk13 force-pushed the fix-jumping-cursor branch from c65ab1b to d1fa157 Compare July 3, 2024 22:16
@Samk13 Samk13 added the bug Something isn't working label Jul 10, 2024
@utnapischtim utnapischtim requested a review from kpsherva July 13, 2024 20:42
@utnapischtim utnapischtim merged commit 5259c8c into inveniosoftware:master Jul 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requests: Cursor keeps getting repositioned when writing comments
3 participants