Errors: Add CommunityNotSelectedError for conditional check on config #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
Sep 17, 2024
| @@ -207,4 +209,16 @@ class ErrorHandlersMixin: | |||
| description="Uploading selected files will result in exceeding the max amount per record.", | |||
| ) | |||
| ), | |||
| CommunityNotSelectedError: create_error_handler( | |||
There was a problem hiding this comment.
this module is not aware of communities (invenio-communities depends on invenio-records-resources, not the other way around) so this handler should be declared either in communities or in rdm-records (a module that is aware both of the record and communities is the correct place)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: CERNDocumentServer/cds-rdm#88