records: added link template for read_many calls. #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandromumo
force-pushed
the
add_links_tpl_to_read_many
branch
from
4441e5b to
6aee359
Compare
alejandromumo
commented
Sep 15, 2023
| @@ -17,7 +17,9 @@ class RecordLink(Link): | |||
| @staticmethod | |||
| def vars(record, vars): | |||
| """Variables for the URI template.""" | |||
| vars.update({"id": record.pid.pid_value}) | |||
| pid_value = getattr(record.pid, "pid_value", None) | |||
There was a problem hiding this comment.
Some records don't have record.pid.pid_value yet (e.g. drafts)
alejandromumo
force-pushed
the
add_links_tpl_to_read_many
branch
from
6aee359 to
b77fb15
Compare
alejandromumo
force-pushed
the
add_links_tpl_to_read_many
branch
from
b77fb15 to
88f4c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/zenodo/rdm-project/issues/11