params: deepcopy service config dicts to avoid mutation bugs

inveniosoftware · Sep 28, 2023 · 1a51430 · 1a51430
1 parent 3f188b7
commit 1a51430
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/invenio_records_resources/services/records/params/facets.py b/invenio_records_resources/services/records/params/facets.py
@@ -9,6 +9,7 @@
 
 """Facets parameter interpreter API."""
 
+from copy import deepcopy
 
 from ..facets import FacetsResponse
 from .base import ParamInterpreter
@@ -26,7 +27,7 @@ def __init__(self, config):
     @property
     def facets(self):
         """Get the defined facets."""
-        return self.config.facets
+        return deepcopy(self.config.facets)
 
     def add_filter(self, name, values):
         """Add a filter for a facet."""

diff --git a/invenio_records_resources/services/records/params/pagination.py b/invenio_records_resources/services/records/params/pagination.py
@@ -8,6 +8,8 @@
 
 """Pagination parameter interpreter API."""
 
+from copy import deepcopy
+
 from ....pagination import Pagination
 from ...errors import QuerystringValidationError
 from .base import ParamInterpreter
@@ -18,7 +20,7 @@ class PaginationParam(ParamInterpreter):
 
     def apply(self, identity, search, params):
         """Evaluate the query str on the search."""
-        options = self.config.pagination_options
+        options = deepcopy(self.config.pagination_options)
 
         default_size = options["default_results_per_page"]