Optional doi fixes

[zzacharo]

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[kpsherva]

sorry for commenting so late on this.
The variable name is a bit confusing without DOI context (it could be interpreted as anything and we will forget this)
how about something like

Suggested change

	if (draft.noINeedOne) {
	if (draft.DOIneededOption) {

or at least noINeedDOI
please ignore if changing this is too complex now, can be done in a separate PR

[kpsherva]

Suggested change

	let recordCopy = {
	const recordCopy = {

[kpsherva]

for readability

Suggested change

	if "doi" not in required_schemes and not self.service.check_permission(
	identity, "pid_manage"
	):
	doi_required = "doi" in required_schemes
	can_manage_dois = self.service.check_permission(
	identity, "pid_manage"
	)
	if not doi_required and not can_manage_doi:

[ntarocco]

LGTM, I agree with the comments of Karolina :)