doi: handle UI for optional DOI feature #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
force-pushed
the
optional-doi-feature
branch
3 times, most recently
from
33af9cd to
404339b
Compare
zzacharo
force-pushed
the
optional-doi-feature
branch
8 times, most recently
from
e77fb48 to
b6287de
Compare
kpsherva
reviewed
Dec 12, 2024
...ssets/semantic-ui/js/invenio_rdm_records/src/deposit/controls/PublishButton/PublishButton.js
Outdated
Show resolved
Hide resolved
zzacharo
force-pushed
the
optional-doi-feature
branch
4 times, most recently
from
0d0b336 to
57f5113
Compare
|
Current implementation First version - no or external DOIIn any subsequent version, we check on the backend that you cannot ask for a locally managed DOI Screenshot
First version - locally managed DOIIn any subsequent version, we check on the backend that you cannot add an external or omit DOI Screenshot
|
zzacharo
force-pushed
the
optional-doi-feature
branch
from
57f5113 to
fdea96d
Compare
kpsherva
reviewed
Dec 13, 2024
| const errorData = error.response.data; | ||
| let errorData = error.response.data; | ||
| const errors = this.recordSerializer.deserializeErrors( | ||
| error.response.data.errors || [] |
There was a problem hiding this comment.
why do we need the empty array?
kpsherva
reviewed
Dec 13, 2024
Comment on lines
385
to
391
| isManagedSelected: | ||
| isDraft === true && value?.identifier && value?.provider !== PROVIDER_EXTERNAL | ||
| ? true | ||
| : undefined, | ||
| isNoNeedSelected: undefined, |
There was a problem hiding this comment.
Suggested change
| isManagedSelected: | |
| isDraft === true && value?.identifier && value?.provider !== PROVIDER_EXTERNAL | |
| ? true | |
| : undefined, | |
| isNoNeedSelected: undefined, | |
| const isInternalProvider = value?.provider !== PROVIDER_EXTERNAL; | |
| const isDraft = record?.is_draft == true; | |
| const hasIdentifier = value?.identifier; | |
| const isManagedSelected = isDraft && hasIdentifier && isInternalProvider ? true : undefined; | |
| this.state = { | |
| isManagedSelected: isManagedSelected; | |
| isNoNeedSelected: undefined, |
also, why do we set isManagedSelected to undefined not false?
kpsherva
reviewed
Dec 13, 2024
| @@ -407,40 +442,72 @@ class CustomPIDField extends Component { | |||
| } | |||
|
|
|||
| const hasManagedIdentifier = managedIdentifier !== ""; | |||
| const hasUnmanagedIdentifier = unmanagedIdentifier !== ""; | |||
There was a problem hiding this comment.
why do we set empty string ?
There was a problem hiding this comment.
The initialization happens above and here we check if the value is not empty string. I am confused about the question :)
zzacharo
force-pushed
the
optional-doi-feature
branch
from
fdea96d to
47712af
Compare
zzacharo
force-pushed
the
optional-doi-feature
branch
from
47712af to
08f080b
Compare
* closes CERNDocumentServer/cds-rdm#163 Co-authored-by: Zacharias Zacharodimos <[email protected]>
zzacharo
force-pushed
the
optional-doi-feature
branch
from
08f080b to
1c177e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If DOI is required:
If DOI is not required:
Different options overview:
Errors displaying that DOI was needed, but was not reserved (on publish of the draft):
