Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serializer: updated subjects and affiliations links in dcat #1890

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

0einstein0
Copy link
Member

❤️ Thank you for your contribution!

Description

Included subject identifiers in datacite schema to extract the URI
Partially fixes: #1889

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@0einstein0 0einstein0 mentioned this pull request Nov 28, 2024
@0einstein0 0einstein0 marked this pull request as ready for review December 3, 2024 12:17
@0einstein0 0einstein0 force-pushed the dcat-fixes branch 2 times, most recently from 302cb15 to 3e7af5e Compare December 3, 2024 15:38
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding of identifiers LGTM, but some of the changes for adapting to DCAT might be too intrusive for the DataCite serialization. Let's discuss IRL probably

@0einstein0 0einstein0 force-pushed the dcat-fixes branch 3 times, most recently from 85127d5 to 1dec1ed Compare December 4, 2024 14:33
@0einstein0 0einstein0 changed the title schema: added identifiers in subjects for datacite serializer: updated subjects and affiliations links in dcat Dec 4, 2024
@0einstein0 0einstein0 requested a review from slint December 4, 2024 14:37
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for moving them back 🫡

@0einstein0 0einstein0 force-pushed the dcat-fixes branch 3 times, most recently from 165c3c6 to 1ff2653 Compare December 5, 2024 08:42
@slint
Copy link
Member

slint commented Dec 6, 2024

I think when inveniosoftware/invenio-vocabularies#446 is merged and released, tests here will start failing. Can you have a look at running all the tests here locally with the vocabularies PR checked locally?

@slint slint merged commit 49a9770 into inveniosoftware:master Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCAT export fixes
2 participants