-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serializer: updated subjects and affiliations links in dcat #1890
Conversation
04fa07c
to
58ccdd5
Compare
302cb15
to
3e7af5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding of identifiers
LGTM, but some of the changes for adapting to DCAT might be too intrusive for the DataCite serialization. Let's discuss IRL probably
85127d5
to
1dec1ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for moving them back 🫡
165c3c6
to
1ff2653
Compare
I think when inveniosoftware/invenio-vocabularies#446 is merged and released, tests here will start failing. Can you have a look at running all the tests here locally with the vocabularies PR checked locally? |
1ff2653
to
cf58b5d
Compare
❤️ Thank you for your contribution!
Description
Included subject identifiers in datacite schema to extract the URI
Partially fixes: #1889
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: