Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services: Communities: Add feature to require community based on config #1813

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Services: Communities: Add feature to require community based on config #1813

merged 6 commits into from
Oct 16, 2024

Conversation

sakshamarora1
Copy link
Contributor

@sakshamarora1 sakshamarora1 commented Sep 16, 2024 •
edited
Loading

@sakshamarora1 sakshamarora1 force-pushed the feature/require_community branch from a82a866 to 385c788 Compare September 16, 2024 15:39
@sakshamarora1 sakshamarora1 force-pushed the feature/require_community branch from c99e2be to c68f63b Compare September 23, 2024 13:26
@sakshamarora1 sakshamarora1 force-pushed the feature/require_community branch from 7a2cb3d to daa9e94 Compare September 23, 2024 15:41
@kpsherva
Copy link
Contributor

UI comment: could you make sure the background on the error message is uniform? otherwise it looks like a bug

@sakshamarora1
Copy link
Contributor Author

Looks like there was some issue with my assets watch command, the UI looks fine after I created a new instance in a new virtual env.
Screenshot 2024-09-26 at 11 22 05

Also, reopened inveniosoftware/invenio-app-rdm#2846, as it was erroring out when you try to remove a community that has already been removed from another tab/window.

ntarocco
ntarocco reviewed Sep 30, 2024
View reviewed changes
invenio_rdm_records/services/communities/service.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/communities/service.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/communities/service.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/permissions.py Show resolved Hide resolved
invenio_rdm_records/config.py Outdated Show resolved Hide resolved
ntarocco
ntarocco reviewed Oct 2, 2024
View reviewed changes
invenio_rdm_records/services/permissions.py Show resolved Hide resolved
invenio_rdm_records/services/errors.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/errors.py Outdated Show resolved Hide resolved
@sakshamarora1 sakshamarora1 force-pushed the feature/require_community branch from 871fe66 to f857b4a Compare October 2, 2024 12:54
ntarocco
ntarocco reviewed Oct 4, 2024
View reviewed changes
invenio_rdm_records/services/permissions.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/permissions.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/permissions.py Outdated Show resolved Hide resolved
alejandromumo
alejandromumo reviewed Oct 4, 2024
View reviewed changes
invenio_rdm_records/resources/config.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/communities/service.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/errors.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/services.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/services.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@Samk13 Samk13 mentioned this pull request Oct 8, 2024
Closed
1 task
@sakshamarora1 sakshamarora1 linked an issue Oct 9, 2024 that may be closed by this pull request
Require a community when uploading inveniosoftware/product-rdm#183
Open
@sakshamarora1 sakshamarora1 force-pushed the feature/require_community branch from fe8f0c5 to 7f9ab8a Compare October 9, 2024 11:48
@sakshamarora1 sakshamarora1 force-pushed the feature/require_community branch from 7f9ab8a to ca0f767 Compare October 15, 2024 09:40
@sakshamarora1 sakshamarora1 force-pushed the feature/require_community branch from ca0f767 to 5a99355 Compare October 15, 2024 14:49
@kpsherva kpsherva merged commit a605015 into inveniosoftware:master Oct 16, 2024
4 checks passed
This was referenced Oct 16, 2024
Closed
Closed
Merged
Open
@Steven-Eardley Steven-Eardley mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzacharo zzacharo zzacharo left review comments

@alejandromumo alejandromumo alejandromumo left review comments

@kpsherva kpsherva kpsherva approved these changes

@Samk13 Samk13 Samk13 approved these changes

@ntarocco ntarocco ntarocco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require a community when uploading Require a community when uploading
6 participants
@sakshamarora1 @kpsherva @ntarocco @alejandromumo @zzacharo @Samk13