Add overridable wrapper to CreatibutorsModal role SelectField #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope this overriadable ID |
|
Hi @kpsherva could you please look into this? Would it be possible to merge this or is something missing? |
|
could you remove the merge commits and push again? steps:
|
SarahW91
force-pushed
the
creatibutor-modal-overridable
branch
from
4d5e9d9 to
d91abc8
Compare
I did and I hope this works for you now, @carlinmack. If it does, could you please merge now? |
SarahW91
force-pushed
the
creatibutor-modal-overridable
branch
from
d91abc8 to
ecbd94b
Compare
kpsherva
reviewed
Sep 16, 2024
...semantic-ui/js/invenio_rdm_records/src/deposit/fields/CreatibutorsField/CreatibutorsField.js
Outdated
Show resolved
Hide resolved
kpsherva
reviewed
Sep 16, 2024
...semantic-ui/js/invenio_rdm_records/src/deposit/fields/CreatibutorsField/CreatibutorsModal.js
Outdated
Show resolved
Hide resolved
|
After merging master into this branch, test fail. |
ntarocco
approved these changes
Nov 18, 2024
Add Overridable wrapper to role SelectField Add props to Overridable CreatibutorsModalRoleSelectField.Container Remove Overridable Context Adjust spacing
…r/invenio-rdm-records into creatibutor-modal-overridable
Add Overridable wrapper to role SelectField Add props to Overridable CreatibutorsModalRoleSelectField.Container Remove Overridable Context Adjust spacing Add OverridableContext.Provider to CreatibutorsModal Add Overridable wrapper to role SelectField Add props to Overridable CreatibutorsModalRoleSelectField.Container Remove Overridable Context Adjust spacing UI: display all affiliations jsonschemas: backport "internal_notes" to v6.0.0 * Backports the "internal_notes" field to the v6.0.0 JSONSchema, since it is backwards compatible, and thus doesn't require any record migration overhead. tests: tepmorarily disable failing user-moderation test tokens: disable "sub" verification * According to the JWT Specification (https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.2) `sub` has to be a string. PyJWT v2.10.0 started enforcing this validation, which breaks our usage of storing an object in the `sub` field. * Fixes jwt.decode options for specifying required fields. 📦 release: v16.1.0
…r/invenio-rdm-records into creatibutor-modal-overridable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: