Fix draft access when published record deleted #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
force-pushed
the
fix-draft-access-when-published-record-deleted
branch
from
99ee684 to
63ca84d
Compare
zzacharo
commented
Oct 23, 2023
| record = self.record_cls.pid.resolve(id_) | ||
| if record.deletion_status.is_deleted: | ||
| result = super().read(identity, id_, expand=expand) | ||
| raise RecordDeletedException(record, result_item=result) |
There was a problem hiding this comment.
this will result in /uploads/<id> giving back the record's tombstone's page
slint
approved these changes
Oct 23, 2023
| # reindex associated draft | ||
| try: | ||
| draft = self.draft_cls.pid.resolve(id_) | ||
| uow.register(RecordIndexOp(draft, indexer=self.indexer)) |
There was a problem hiding this comment.
Suggested change
| uow.register(RecordIndexOp(draft, indexer=self.indexer)) | |
| uow.register(RecordIndexOp(draft, indexer=self.draft_indexer)) |
I recently found out, this is a thing :)
ditto above I guess when deleting from the index.
zzacharo
force-pushed
the
fix-draft-access-when-published-record-deleted
branch
from
63ca84d to
5b2662a
Compare
zzacharo
force-pushed
the
fix-draft-access-when-published-record-deleted
branch
from
5b2662a to
a5f853d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires inveniosoftware/invenio-records-resources#533
closes https://github.com/zenodo/rdm-project/issues/430