Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1454 notifications replace guest access request notification #1465

Conversation

rekt-hard
Copy link
Contributor

@rekt-hard rekt-hard commented Sep 13, 2023

❤️ Thank you for your contribution!

Description

closes #1454
addresses sending out emails on submit: https://github.com/zenodo/rdm-project/issues/11#issuecomment-1708483567
depends on inveniosoftware/invenio-users-resources#111

Replaces EmailOp with NotficationOp. This will allow easy customization of sent notifications.
Send notification on guest access submit action.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@rekt-hard
Copy link
Contributor Author

General note on templates: The exact wording should be discussed and if the user info should be included as well. Something like ... was submitted by {full_name} ({email}) would be nice.

@rekt-hard rekt-hard force-pushed the 1454-notifications-replace-guest-access-request-notification branch from fa01974 to a2318e2 Compare September 13, 2023 13:31
@rekt-hard rekt-hard linked an issue Sep 13, 2023 that may be closed by this pull request
@rekt-hard rekt-hard force-pushed the 1454-notifications-replace-guest-access-request-notification branch from a2318e2 to 8fc48d3 Compare October 3, 2023 14:58
@zzacharo zzacharo merged commit 8754b5c into inveniosoftware:master Oct 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants