Various fixes #1456
Merged
Various fixes #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-moser
commented
Sep 11, 2023
Comment on lines
+156
to
+158
| "The record %(rec_id)s in not included in the community %(com_id)s.", | ||
| rec_id=self.record_id, | ||
| com_id=self.community_id, |
There was a problem hiding this comment.
The original discussion regarding translations can be found here
* use relative imports for invenio_rdm_records * remove unused imports
* lazy_gettext uses the %(variable)s formatting to insert variables into the translated text * with f-strings, we would be inserting the variables before the translation happens
zzacharo
force-pushed
the
mm/various-fixes
branch
from
dddd423 to
59a4f94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the commits that were originally added on top of #1450