serializers: replace slugs caching with invenio-cache

inveniosoftware · Oct 2, 2023 · 78e0098 · 78e0098
1 parent fd4a8a4
commit 78e0098
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 17 deletions.
diff --git a/invenio_rdm_records/resources/serializers/datacite/schema.py b/invenio_rdm_records/resources/serializers/datacite/schema.py
@@ -9,8 +9,6 @@
 
 """DataCite based Schema for Invenio RDM Records."""
 
-import time
-
 from edtf import parse_edtf
 from edtf.parser.grammar import ParseException
 from flask import current_app
@@ -436,11 +434,8 @@ def get_related_identifiers(self, obj):
         # adding communities
         communities = obj.get("parent", {}).get("communities", {}).get("ids", [])
         service_id = current_communities.service.id
-        one_hour_cache = round(time.time() / 3600)
         for community_id in communities:
-            slug = get_cached_community_slug(
-                community_id, service_id, ttl_hash=one_hour_cache
-            )
+            slug = get_cached_community_slug(community_id, service_id)
             url = f"{current_app.config['SITE_UI_URL']}/communities/{slug}"
             serialized_identifiers.append(
                 {

diff --git a/invenio_rdm_records/resources/serializers/dublincore/schema.py b/invenio_rdm_records/resources/serializers/dublincore/schema.py
@@ -7,8 +7,6 @@
 
 """Dublin Core based Schema for Invenio RDM Records."""
 
-import time
-
 import bleach
 import idutils
 from flask import current_app
@@ -107,11 +105,8 @@ def get_relations(self, obj):
         # Communities
         communities = obj["parent"].get("communities", {}).get("ids", [])
         service_id = current_communities.service.id
-        one_hour_cache = round(time.time() / 3600)
         for community_id in communities:
-            slug = get_cached_community_slug(
-                community_id, service_id, ttl_hash=one_hour_cache
-            )
+            slug = get_cached_community_slug(community_id, service_id)
             url = f"{current_app.config['SITE_UI_URL']}/communities/{slug}"
             rels.append(self._transform_identifier(url, "url"))
 

diff --git a/invenio_rdm_records/resources/serializers/marcxml/schema.py b/invenio_rdm_records/resources/serializers/marcxml/schema.py
@@ -7,8 +7,6 @@
 
 """MARCXML based Schema for Invenio RDM Records."""
 
-import time
-
 import bleach
 from dateutil.parser import parse
 from flask import current_app, g
@@ -133,10 +131,8 @@ def get_sizes(self, obj):
     def _get_communities_slugs(self, ids):
         """Get communities slugs."""
         service_id = current_communities.service.id
-        one_hour_cache = round(time.time() / 3600)
         return [
-            get_cached_community_slug(community_id, service_id, ttl_hash=one_hour_cache)
-            for community_id in ids
+            get_cached_community_slug(community_id, service_id) for community_id in ids
         ]
 
     def get_communities(self, obj):