Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Improve display of ZIPs with long file names #195

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Dec 15, 2023

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Before

image

Narrow viewport

image

After

image

Narrow viewport

image

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

* stretched ensures that the expand button increases its vertical height

* one wide ensures that 11/12 of the space is given to the title
* with .one.wide on narrow viewports the expand symbol will not have enough space to display

* semantic UI does not provide a class based interface for fixed widths so
  I have used a inline style. see https://stackoverflow.com/q/39926080
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be great to have some padding on the left (so that the text is not right next to the border), but if it was tried and proved painful, we can merge this as is.

@slint slint merged commit 94cb84c into inveniosoftware:master Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants